loader-svn: Rename default branch to HEAD
ClosedPublic
Actions

Authored by ardumont on Oct 10 2018, 6:44 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDLDSVN80adbffa6331: loader: Rename default branch as HEAD

Summary

Open for discussion, i'll adapt according to our conclusion.

I'd prefer the alias mentioned in the task but that does not make
particular sense here since:

we do not rely on svn's convention anyway (we parse the tree directly and do not read any branches information)

'master' was the name i chose without particular thought on this. So keeping this and aliasing it as described sounds not particularly better than that

Related T1257

Test Plan

make test

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1615
Build 1959: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 10 2018, 6:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 10 2018, 6:44 PM

Harbormaster completed remote builds in B1615: Diff 1588.Oct 10 2018, 6:44 PM

zack retitled this revision from loader: Rename default branch as HEAD to loader: Rename default branch to HEAD.Oct 11 2018, 9:01 AM

I didn't think of this in relation to T1257, but it's indeed a very valid point.
For consistency we should certainly have HEAD in svn snapshots too.

At first it sounds weird to also remove master, but upon reflection I think that's just a git-induced bias. master is not a term that was used in svn days, trunk was more dominant.

So, bottom line: I'm fine with this proposal. (Although we will need to update all the existing snapshots, as discussed.)

ardumont retitled this revision from loader: Rename default branch to HEAD to loader-svn: Rename default branch to HEAD.Oct 11 2018, 9:31 AM

olasd accepted this revision.Oct 11 2018, 2:37 PM

This revision is now accepted and ready to land.Oct 11 2018, 2:37 PM

Closed by commit rDLDSVN80adbffa6331: loader: Rename default branch as HEAD (authored by ardumont). · Explain WhyOct 11 2018, 2:46 PM

This revision was automatically updated to reflect the committed changes.