Use the `target` argument to RawExtrinsicMetadata instead of deprecated `id`
ClosedPublic
Actions

Authored by olasd on Nov 3 2020, 3:15 PM.

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE7f4e53aedde7: Use the `target` argument to RawExtrinsicMetadata instead of deprecated `id`

Summary

This argument was deprecated in swh.model v0.7.2

Test Plan

python3 -m pytest -sv --ff -W error:RawExtrinsicMetadata:DeprecationWarning -n 6 (no deprecation warnings left, when using swh.storage master)

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16820
Build 25941: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25940: arc lint + arc unit

Event Timeline

olasd created this revision.Nov 3 2020, 3:15 PM

Build is green

Patch application report for D4402 (id=15597)

Rebasing onto 8f41aeee10...

Current branch diff-target is up to date.

Changes applied before test

commit 7f4e53aedde7b2869804192677995f852d446f8d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Nov 3 15:02:30 2020 +0100

    Use the `target` argument to RawExtrinsicMetadata instead of deprecated `id`
    
    This argument was deprecated in swh.model v0.7.2

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/337/ for more details.

Harbormaster completed remote builds in B16820: Diff 15597.Nov 3 2020, 3:16 PM

olasd edited the test plan for this revision. (Show Details)Nov 3 2020, 3:46 PM

ardumont accepted this revision.Nov 3 2020, 4:45 PM

This revision is now accepted and ready to land.Nov 3 2020, 4:45 PM

ardumont added a reviewer: Reviewers.Nov 3 2020, 4:46 PM

Closed by commit rDLDBASE7f4e53aedde7: Use the `target` argument to RawExtrinsicMetadata instead of deprecated `id` (authored by olasd). · Explain WhyNov 3 2020, 5:10 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLDBASE7f4e53aedde7: Use the `target` argument to RawExtrinsicMetadata instead of deprecated `id`.