Details

Reviewers

Group Reviewers

Commits

rDCORE97c091e04da9: asynchronous.RPCServerApp: Align implementation with api.RPCServerApp

Summary

This will allow to align the few modules declaring client/server code (redundantly) with the
other rpc servers (e.g. vault, objstorage).

Test Plan

tox

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 16529
Build 25470: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25469: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	65 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_server::test_client_batch_cook_invalid_type[pyloop] swh_local_vault_config = {'vault': {'args': {'cache': {'args': {'allow_delete': True, 'root': '/tmp/pytest-of-jenkins/pytest-0/test_client_batc...-of-jenkins/pytest-0/test_client_batch_cook_invalid0', 'slicing': '0:1/1:5'}, 'cls': 'pathslicing'}}}, 'cls': 'local'}} @pytest.fixture
	61 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_server::test_client_batch_progress_notfound[pyloop] swh_local_vault_config = {'vault': {'args': {'cache': {'args': {'allow_delete': True, 'root': '/tmp/pytest-of-jenkins/pytest-0/test_client_batc...-of-jenkins/pytest-0/test_client_batch_progress_not0', 'slicing': '0:1/1:5'}, 'cls': 'pathslicing'}}}, 'cls': 'local'}} @pytest.fixture
	65 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_server::test_client_cook_notfound[pyloop] swh_local_vault_config = {'vault': {'args': {'cache': {'args': {'allow_delete': True, 'root': '/tmp/pytest-of-jenkins/pytest-0/test_client_cook...-of-jenkins/pytest-0/test_client_cook_notfound_pylo0', 'slicing': '0:1/1:5'}, 'cls': 'pathslicing'}}}, 'cls': 'local'}} @pytest.fixture
	65 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_server::test_client_index[pyloop] swh_local_vault_config = {'vault': {'args': {'cache': {'args': {'allow_delete': True, 'root': '/tmp/pytest-of-jenkins/pytest-0/test_client_inde...ytest-of-jenkins/pytest-0/test_client_index_pyloop_0', 'slicing': '0:1/1:5'}, 'cls': 'pathslicing'}}}, 'cls': 'local'}} @pytest.fixture
	65 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.vault.tests.test_server::test_client_progress_notfound[pyloop] swh_local_vault_config = {'vault': {'args': {'cache': {'args': {'allow_delete': True, 'root': '/tmp/pytest-of-jenkins/pytest-0/test_client_prog...-of-jenkins/pytest-0/test_client_progress_notfound_0', 'slicing': '0:1/1:5'}, 'cls': 'pathslicing'}}}, 'cls': 'local'}} @pytest.fixture
		View Full Test Results (7 Failed · 59 Passed)

Event Timeline

ardumont created this revision.Oct 19 2020, 9:59 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 19 2020, 9:59 AM

Build is green

Patch application report for D4299 (id=15187)

Could not rebase; Attempt merge onto 1657fb827f...

Updating 1657fb8..604a08c
Fast-forward
 swh/core/api/asynchronous.py                       | 128 +++++++++++++++++---
 swh/core/api/tests/conftest.py                     |   3 +
 swh/core/api/tests/test_async.py                   |  38 +++---
 swh/core/api/tests/test_rpc_server_asynchronous.py | 132 +++++++++++++++++++++
 tox.ini                                            |   1 +
 5 files changed, 261 insertions(+), 41 deletions(-)
 create mode 100644 swh/core/api/tests/conftest.py
 create mode 100644 swh/core/api/tests/test_rpc_server_asynchronous.py

Changes applied before test

commit 604a08cbe80439b35ce0197805b6a4c536d96e62
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

commit 7f928a07d91460efbbfbc6c5264a4fdd60e58be2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 10:25:01 2020 +0200

    api.tests.test_async: Simplify fixture setup

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/93/ for more details.

Harbormaster completed remote builds in B16422: Diff 15187.Oct 19 2020, 10:00 AM

Are there tests for the backend_factory/backend_class stuff?

swh/core/api/asynchronous.py
44–54 ↗	(On Diff #15187)	not tested?
135–150 ↗	(On Diff #15187)	make this a constant at the class or module level so it doesn't bloat the constructor
162–164 ↗	(On Diff #15187)	that'sa weird logic. It means that if `backend_factory` is not `None` but `backend_class` is, then `backend_factory` is ignored?

ardumont added inline comments.Oct 19 2020, 1:24 PM

swh/core/api/asynchronous.py
44–54 ↗	(On Diff #15187)	I initially added a comment saying i'll add tests on that... But i think it's actually not used. I'll check ;)
162–164 ↗	(On Diff #15187)	yes, strange, coming from the existing rpc server... Maybe we should make those backend_factory and backend_class mandatory. That's how they are used anyway iirc. backend_factory sample: get_storage, etc... backend_class: StorageInterface, ... (that's actually our interfaces now)

ardumont added inline comments.Oct 19 2020, 1:28 PM

swh/core/api/asynchronous.py
162–164 ↗	(On Diff #15187)	maybe mandatory for backend_class but not the backend_factory...

ardumont added inline comments.Oct 19 2020, 1:30 PM

swh/core/api/asynchronous.py
162–164 ↗	(On Diff #15187)	for the record, i was referring to this piece of code earlier [1] [1] https://forge.softwareheritage.org/source/swh-core/browse/master/swh/core/api/__init__.py$434-436

ardumont added inline comments.Oct 19 2020, 3:40 PM

swh/core/api/asynchronous.py
135–150 ↗	(On Diff #15187)	Hmm, unsure on how to properly do that? I'm using the self.extra_type_encoders here.

Drop unneeded function (most likely an intermediary method i forgot to clean up)

swh/core/api/asynchronous.py
44–54 ↗	(On Diff #15187)	`encode_data` was not needed, so dropped.

Build is green

Patch application report for D4299 (id=15217)

Could not rebase; Attempt merge onto 7f928a07d9...

Updating 7f928a0..b920fae
Fast-forward
 mypy.ini                                           |   3 +
 requirements-db.txt                                |   1 +
 requirements-test-db.txt                           |   2 +-
 swh/core/api/asynchronous.py                       | 115 +++++++++++++++---
 swh/core/api/tests/conftest.py                     |   3 +
 swh/core/api/tests/test_rpc_server_asynchronous.py | 132 +++++++++++++++++++++
 swh/core/db/db_utils.py                            | 104 +++++++++++++++-
 swh/core/db/pytest_plugin.py                       |  59 +++++++++
 swh/core/db/tests/conftest.py                      |   2 +
 swh/core/db/tests/data/0-schema.sql                |  13 ++
 swh/core/db/tests/data/1-data.sql                  |  10 ++
 swh/core/db/tests/test_db_utils.py                 |  56 +++++++++
 tox.ini                                            |   1 +
 13 files changed, 482 insertions(+), 19 deletions(-)
 create mode 100644 swh/core/api/tests/conftest.py
 create mode 100644 swh/core/api/tests/test_rpc_server_asynchronous.py
 create mode 100644 swh/core/db/pytest_plugin.py
 create mode 100644 swh/core/db/tests/data/0-schema.sql
 create mode 100644 swh/core/db/tests/data/1-data.sql
 create mode 100644 swh/core/db/tests/test_db_utils.py

Changes applied before test

commit b920faec4c4d9ee0b871e9fd6c3f26ec2dd0d1d8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

commit 28f8e7ab54cdeb7ed6d6f474bb6c89e891638236
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 14:46:39 2020 +0200

    Install postgresql_fact fixture for faster postgres tests
    
    This moves the SWHDatabaseJanitor from swh.storage to swh.core. This also adds
    tests to it.
    
    This will allow to share the behavior on other swh services with postgres
    backends (vault, scheduler, etc...).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/95/ for more details.

Harbormaster completed remote builds in B16452: Diff 15217.Oct 19 2020, 3:53 PM

Add missing coverage in impacted code

Build is green

Patch application report for D4299 (id=15218)

Could not rebase; Attempt merge onto 7f928a07d9...

Updating 7f928a0..afdd9e6
Fast-forward
 mypy.ini                                           |   3 +
 requirements-db.txt                                |   1 +
 requirements-test-db.txt                           |   2 +-
 swh/core/api/asynchronous.py                       | 115 +++++++++++++++---
 swh/core/api/tests/conftest.py                     |   3 +
 swh/core/api/tests/test_async.py                   |  25 +++-
 swh/core/api/tests/test_rpc_server_asynchronous.py | 132 +++++++++++++++++++++
 swh/core/db/db_utils.py                            | 104 +++++++++++++++-
 swh/core/db/pytest_plugin.py                       |  59 +++++++++
 swh/core/db/tests/conftest.py                      |   2 +
 swh/core/db/tests/data/0-schema.sql                |  13 ++
 swh/core/db/tests/data/1-data.sql                  |  10 ++
 swh/core/db/tests/test_db_utils.py                 |  56 +++++++++
 tox.ini                                            |   1 +
 14 files changed, 506 insertions(+), 20 deletions(-)
 create mode 100644 swh/core/api/tests/conftest.py
 create mode 100644 swh/core/api/tests/test_rpc_server_asynchronous.py
 create mode 100644 swh/core/db/pytest_plugin.py
 create mode 100644 swh/core/db/tests/data/0-schema.sql
 create mode 100644 swh/core/db/tests/data/1-data.sql
 create mode 100644 swh/core/db/tests/test_db_utils.py

Changes applied before test

commit afdd9e689ab45cdeb837b65aa6e034edadc101f4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

commit 28f8e7ab54cdeb7ed6d6f474bb6c89e891638236
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 14:46:39 2020 +0200

    Install postgresql_fact fixture for faster postgres tests
    
    This moves the SWHDatabaseJanitor from swh.storage to swh.core. This also adds
    tests to it.
    
    This will allow to share the behavior on other swh services with postgres
    backends (vault, scheduler, etc...).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/96/ for more details.

Harbormaster completed remote builds in B16453: Diff 15218.Oct 19 2020, 4:10 PM

vlorentz added inline comments.Oct 19 2020, 4:28 PM

swh/core/api/asynchronous.py
135–150 ↗	(On Diff #15187)	oh right. Then make it a method. The point is, I like to have the `super()` call as close as possible to the beginning (or the end) of a function

Rebase
extract renderers into a method to simplify the constructor reading

Build is green

Patch application report for D4299 (id=15235)

Could not rebase; Attempt merge onto 7f928a07d9...

Updating 7f928a0..c8714b9
Fast-forward
 mypy.ini                                           |   3 +
 requirements-db.txt                                |   1 +
 requirements-test-db.txt                           |   2 +-
 swh/core/api/asynchronous.py                       | 131 ++++++++++++++++----
 swh/core/api/tests/conftest.py                     |   3 +
 swh/core/api/tests/test_async.py                   |  25 +++-
 swh/core/api/tests/test_rpc_server_asynchronous.py | 132 +++++++++++++++++++++
 swh/core/db/db_utils.py                            | 111 ++++++++++++++++-
 swh/core/db/pytest_plugin.py                       |  59 +++++++++
 swh/core/db/tests/data/0-schema.sql                |  16 +++
 swh/core/db/tests/data/1-data.sql                  |  12 ++
 swh/core/db/tests/test_db_utils.py                 |  67 +++++++++++
 tox.ini                                            |   1 +
 13 files changed, 536 insertions(+), 27 deletions(-)
 create mode 100644 swh/core/api/tests/conftest.py
 create mode 100644 swh/core/api/tests/test_rpc_server_asynchronous.py
 create mode 100644 swh/core/db/pytest_plugin.py
 create mode 100644 swh/core/db/tests/data/0-schema.sql
 create mode 100644 swh/core/db/tests/data/1-data.sql
 create mode 100644 swh/core/db/tests/test_db_utils.py

Changes applied before test

commit c8714b9eb1f5d41cd470a988da416f71215d6fe2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

commit 6b311c8f7794a548c68c786e5adb79dff609843a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 14:46:39 2020 +0200

    Install postgresql_fact fixture for faster postgres tests
    
    This moves the SWHDatabaseJanitor from swh.storage to swh.core. This also adds
    tests to it.
    
    This will allow to share the behavior on other swh services with postgres
    backends (vault, scheduler, etc...).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/99/ for more details.

Harbormaster completed remote builds in B16468: Diff 15235.Oct 19 2020, 6:47 PM

Use the endpoint-path and not the method name as rpc server endpoint
Drop the unneeded asyncio coroutine import

ardumont marked 3 inline comments as done.Oct 20 2020, 1:30 PM

Build is green

Patch application report for D4299 (id=15255)

Could not rebase; Attempt merge onto 7f928a07d9...

Updating 7f928a0..4a45166
Fast-forward
 mypy.ini                                           |   3 +
 requirements-db.txt                                |   1 +
 requirements-test-db.txt                           |   2 +-
 swh/core/api/asynchronous.py                       | 130 ++++++++++++++++----
 swh/core/api/tests/conftest.py                     |   3 +
 swh/core/api/tests/test_async.py                   |  25 +++-
 swh/core/api/tests/test_rpc_server_asynchronous.py | 132 +++++++++++++++++++++
 swh/core/db/db_utils.py                            | 111 ++++++++++++++++-
 swh/core/db/pytest_plugin.py                       |  59 +++++++++
 swh/core/db/tests/data/0-schema.sql                |  16 +++
 swh/core/db/tests/data/1-data.sql                  |  12 ++
 swh/core/db/tests/test_db_utils.py                 |  67 +++++++++++
 tox.ini                                            |   1 +
 13 files changed, 535 insertions(+), 27 deletions(-)
 create mode 100644 swh/core/api/tests/conftest.py
 create mode 100644 swh/core/api/tests/test_rpc_server_asynchronous.py
 create mode 100644 swh/core/db/pytest_plugin.py
 create mode 100644 swh/core/db/tests/data/0-schema.sql
 create mode 100644 swh/core/db/tests/data/1-data.sql
 create mode 100644 swh/core/db/tests/test_db_utils.py

Changes applied before test

commit 4a4516643331221d3499b9d9e777b0eb1ca66257
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

commit 6b311c8f7794a548c68c786e5adb79dff609843a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 14:46:39 2020 +0200

    Install postgresql_fact fixture for faster postgres tests
    
    This moves the SWHDatabaseJanitor from swh.storage to swh.core. This also adds
    tests to it.
    
    This will allow to share the behavior on other swh services with postgres
    backends (vault, scheduler, etc...).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/100/ for more details.

Harbormaster completed remote builds in B16487: Diff 15255.Oct 20 2020, 1:30 PM

ardumont edited the summary of this revision. (Show Details)Oct 20 2020, 1:30 PM

ardumont edited the summary of this revision. (Show Details)

Rebase
use the endpoint path name as rpc endpoint path (and not the method name)

Build is green

Patch application report for D4299 (id=15288)

Could not rebase; Attempt merge onto 7f928a07d9...

Updating 7f928a0..e55490d
Fast-forward
 mypy.ini                                           |   3 +
 requirements-db.txt                                |   1 +
 requirements-test-db.txt                           |   2 +-
 swh/core/api/asynchronous.py                       | 130 +++++++++++++++----
 swh/core/api/tests/conftest.py                     |   3 +
 swh/core/api/tests/test_async.py                   |  25 +++-
 swh/core/api/tests/test_rpc_server_asynchronous.py | 132 +++++++++++++++++++
 swh/core/db/db_utils.py                            | 118 ++++++++++++++++-
 swh/core/db/pytest_plugin.py                       |  62 +++++++++
 swh/core/db/tests/data/0-schema.sql                |  19 +++
 swh/core/db/tests/data/1-data.sql                  |  15 +++
 swh/core/db/tests/test_db_utils.py                 | 142 +++++++++++++++++++++
 tox.ini                                            |   1 +
 13 files changed, 625 insertions(+), 28 deletions(-)
 create mode 100644 swh/core/api/tests/conftest.py
 create mode 100644 swh/core/api/tests/test_rpc_server_asynchronous.py
 create mode 100644 swh/core/db/pytest_plugin.py
 create mode 100644 swh/core/db/tests/data/0-schema.sql
 create mode 100644 swh/core/db/tests/data/1-data.sql
 create mode 100644 swh/core/db/tests/test_db_utils.py

Changes applied before test

commit e55490d737d1fab7af75d91c80f3e9df0ee86590
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

commit 0c01f4a09284b8843ac238f61f0a9f3ba3a0cd7a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Oct 18 14:46:39 2020 +0200

    Install postgresql_fact fixture for faster postgres tests
    
    This moves the SWHDatabaseJanitor from swh.storage to swh.core. This also adds
    tests to it.
    
    This will allow to share the behavior on other swh services with postgres
    backends (vault, scheduler, etc...).

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/102/ for more details.

Harbormaster completed remote builds in B16519: Diff 15288.Oct 21 2020, 6:06 PM

ardumont marked an inline comment as done.Oct 22 2020, 11:13 AM

Rebase

Use the correct repository to sync the diff ¯\_(ツ)_/¯ (again!)

Build has FAILED

Patch application report for D4299 (id=15301)

Could not rebase; Attempt merge onto 97a860997b...

Updating 97a8609..8274a55
Fast-forward
 requirements.txt                     |   2 +-
 swh/vault/api/client.py              |  48 +-------
 swh/vault/api/server.py              | 228 ++++++++++-------------------------
 swh/vault/backend.py                 | 176 +++++++++++++++++----------
 swh/vault/cookers/__init__.py        |  21 +++-
 swh/vault/cookers/base.py            |   4 +-
 swh/vault/interface.py               |  68 +++++++++++
 swh/vault/tests/conftest.py          |  17 ++-
 swh/vault/tests/test_backend.py      |  22 +++-
 swh/vault/tests/test_cookers_base.py |   6 +-
 swh/vault/tests/test_init_cookers.py | 109 +++++++++++++++++
 swh/vault/tests/test_server.py       | 128 +++++++++++++++++---
 12 files changed, 520 insertions(+), 309 deletions(-)
 create mode 100644 swh/vault/interface.py
 create mode 100644 swh/vault/tests/test_init_cookers.py

Changes applied before test

commit 8274a551a888a36de3afa166732b00c983c670ba
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 18:12:18 2020 +0200

    vault.server: Introduce a typed VaultInterface
    
    This allows to drop redundant code in between rpc server and clients using the
    base class from swh.core.api.async module.

commit eb868d0e690e9890172b699184bcffb80696fe89
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Oct 20 15:15:52 2020 +0200

    Add tests on current configuration check for cooker instantiation

commit e5e428481c76966cf253d914ca1276c7c9749e69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 20:06:00 2020 +0200

    api.server: Add types and tests on configuration checks

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/33/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/33/console

Harbormaster failed remote builds in B16529: Diff 15301!Oct 22 2020, 12:17 PM

Build is green

Patch application report for D4299 (id=15302)

Rebasing onto 0c01f4a092...

Current branch diff-target is up to date.

Changes applied before test

commit e55490d737d1fab7af75d91c80f3e9df0ee86590
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/103/ for more details.

Harbormaster completed remote builds in B16530: Diff 15302.Oct 22 2020, 12:18 PM

Adapt according to discussion

Build is green

Patch application report for D4299 (id=15308)

Rebasing onto 0c01f4a092...

Current branch diff-target is up to date.

Changes applied before test

commit 8cf0f1a1cd95060a3e1a78fe3ce58438a4d76f78
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/104/ for more details.

Harbormaster completed remote builds in B16536: Diff 15308.Oct 22 2020, 1:03 PM

keep the self.backend_class reference

Build is green

Patch application report for D4299 (id=15309)

Rebasing onto 0c01f4a092...

Current branch diff-target is up to date.

Changes applied before test

commit e1a047b5a597a39df1ab2314401e113c95f56af2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/105/ for more details.

Harbormaster completed remote builds in B16537: Diff 15309.Oct 22 2020, 1:05 PM

vlorentz accepted this revision.Oct 22 2020, 1:12 PM

vlorentz added inline comments.

swh/core/api/asynchronous.py
132 ↗	(On Diff #15309)	equivalent to: `backend_factory = backend_factory or backend_class`

This revision is now accepted and ready to land.Oct 22 2020, 1:12 PM

Simplify tests

swh/core/api/asynchronous.py
132 ↗	(On Diff #15309)	but but... yeah... i keep forgetting that form which i prefer btw... Thanks for yet again telling it to me

Build is green

Patch application report for D4299 (id=15313)

Rebasing onto 0c01f4a092...

Current branch diff-target is up to date.

Changes applied before test

commit 301061aa34c0da261a3cb6228f43cddcec88cfd4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/106/ for more details.

Harbormaster completed remote builds in B16541: Diff 15313.Oct 22 2020, 1:14 PM

prefer or form to ternary form

Build is green

Patch application report for D4299 (id=15314)

Rebasing onto 0c01f4a092...

Current branch diff-target is up to date.

Changes applied before test

commit 97c091e04da9ec51cbc0b7f1e23dbe61eb553e81
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat Oct 17 19:06:57 2020 +0200

    asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
    
    This will allow to align the Vault's client/server code with the other rpc
    servers. And start adding one typed interface with more consistent checks in
    between implementations.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/107/ for more details.

Harbormaster completed remote builds in B16542: Diff 15314.Oct 22 2020, 1:18 PM

Closed by commit rDCORE97c091e04da9: asynchronous.RPCServerApp: Align implementation with api.RPCServerApp (authored by ardumont). · Explain WhyOct 22 2020, 1:19 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE97c091e04da9: asynchronous.RPCServerApp: Align implementation with api.RPCServerApp.

asynchronous.RPCServerApp: Align implementation with api.RPCServerAppClosedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Patch application report for D4299 (id=15187)

Changes applied before test

Patch application report for D4299 (id=15217)

Changes applied before test

Patch application report for D4299 (id=15218)

Changes applied before test

Patch application report for D4299 (id=15235)

Changes applied before test

Patch application report for D4299 (id=15255)

Changes applied before test

Patch application report for D4299 (id=15288)

Changes applied before test

Patch application report for D4299 (id=15301)

Changes applied before test

Patch application report for D4299 (id=15302)

Changes applied before test

Patch application report for D4299 (id=15308)

Changes applied before test

Patch application report for D4299 (id=15309)

Changes applied before test

Patch application report for D4299 (id=15313)

Changes applied before test

Patch application report for D4299 (id=15314)

Changes applied before test

Revision ContentsChangeset List

Diff 15301

requirements.txt

swh/vault/api/client.py

swh/vault/api/server.py

swh/vault/backend.py

swh/vault/cookers/base.py

swh/vault/interface.py

swh/vault/tests/conftest.py

swh/vault/tests/test_backend.py

swh/vault/tests/test_cookers_base.py

swh/vault/tests/test_server.py

asynchronous.RPCServerApp: Align implementation with api.RPCServerApp
ClosedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List