Page MenuHomeSoftware Heritage
Differential D4295

Add types and tests on configuration checks
ClosedPublic
Actions

Authored by ardumont on Oct 16 2020, 8:05 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDVAUeb868d0e690e: Add tests on current configuration check for cooker instantiation
rDVAUe5e428481c76: api.server: Add types and tests on configuration checks
Summary

So actual configuration is tested.

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Oct 16 2020, 8:05 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2020, 8:05 PM
swh-public-ci added a comment.Oct 16 2020, 8:07 PM

Build is green

Patch application report for D4295 (id=15178)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..893591b
Fast-forward
 requirements-test.txt          |  1 +
 swh/vault/__init__.py          | 53 +++++++++++++++++++++++++---------------
 swh/vault/api/server.py        | 21 ++++++++--------
 swh/vault/backend.py           | 13 ++++++----
 swh/vault/tests/conftest.py    | 46 +++++++++++++++++------------------
 swh/vault/tests/test_init.py   | 55 ++++++++++++++++++++++++++++++++++++++++++
 swh/vault/tests/test_server.py | 38 ++++++++++++++++++++++++++++-
 7 files changed, 167 insertions(+), 60 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit 893591b05d78d1706f48144562382aedb55d6c49
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 20:06:00 2020 +0200

    api.server: Add types and tests on configuration checks

commit efd5eb4dbdb3b451997141b661cb9ae53b8c3c34
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/23/ for more details.

Harbormaster completed remote builds in B16407: Diff 15178.Oct 16 2020, 8:07 PM
ardumont updated this revision to Diff 15194.Oct 19 2020, 12:11 PM

Rebase

swh-public-ci added a comment.Oct 19 2020, 12:14 PM

Build is green

Patch application report for D4295 (id=15194)

Could not rebase; Attempt merge onto b5cecff6df...

Updating b5cecff..7eb906e
Fast-forward
 requirements-test.txt          |  1 +
 swh/vault/__init__.py          | 53 +++++++++++++++++++++++++---------------
 swh/vault/api/server.py        | 16 ++++++------
 swh/vault/backend.py           | 13 ++++++----
 swh/vault/tests/conftest.py    | 46 +++++++++++++++++------------------
 swh/vault/tests/test_init.py   | 55 ++++++++++++++++++++++++++++++++++++++++++
 swh/vault/tests/test_server.py | 38 ++++++++++++++++++++++++++++-
 7 files changed, 166 insertions(+), 56 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit 7eb906ea76ad11ceacd0fb153690c2cdf233c742
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 20:06:00 2020 +0200

    api.server: Add types and tests on configuration checks

commit 8e4026a5e8c9d43832cd3b038b9175f3f4914407
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/25/ for more details.

Harbormaster completed remote builds in B16430: Diff 15194.Oct 19 2020, 12:14 PM
ardumont mentioned this in D4294: swh.vault: Unify get_vault factory function with other factories.Oct 19 2020, 12:25 PM
vlorentz requested changes to this revision.Oct 19 2020, 12:43 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/vault/tests/test_server.py
62

what is this %?

69

black folded the lines

91

you can remove , "This should not raise", it's redundant

This revision now requires changes to proceed.Oct 19 2020, 12:43 PM
ardumont added inline comments.Oct 19 2020, 1:05 PM
swh/vault/tests/test_server.py
62

no idea ;)

ardumont updated this revision to Diff 15215.Oct 19 2020, 3:13 PM

Adapt according to review:

  • Drop % in configuration key
  • Merge 2 strings in one
  • Drop the redundant message in assertion failure
swh-public-ci added a comment.Oct 19 2020, 3:22 PM

Build is green

Patch application report for D4295 (id=15215)

Rebasing onto 49d787c185...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-1012-D4295.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1012/ for more details.
Harbormaster completed remote builds in B16450: Diff 15215.Oct 19 2020, 3:22 PM
ardumont updated this revision to Diff 15216.Oct 19 2020, 3:23 PM
Use the right folder to actually sync the diff ¯\_(ツ)_/¯
swh-public-ci added a comment.Oct 19 2020, 3:25 PM
Build is green



Patch application report for D4295 (id=15216)



Rebasing onto 8e4026a5e8...



Current branch diff-target is up to date.





Changes applied before test



commit a2ffe238d0e59def15ac5dd5a41717f6a5ff63e8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 20:06:00 2020 +0200

    api.server: Add types and tests on configuration checks



See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/26/ for more details.
Harbormaster completed remote builds in B16451: Diff 15216.Oct 19 2020, 3:25 PM
ardumont updated this revision to Diff 15259.Oct 20 2020, 4:15 PM
    

  • Add tests on current configuration check for cooker instantiation
    • 

swh-public-ci added a comment.Oct 20 2020, 4:16 PM
Build is green



Patch application report for D4295 (id=15259)



Rebasing onto 8e4026a5e8...



Current branch diff-target is up to date.





Changes applied before test



commit 829601a7f50ce2cf9c6d7c236d82a3a78e7e4e2f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Oct 20 15:15:52 2020 +0200

    Add tests on current configuration check for cooker instantiation

commit a2ffe238d0e59def15ac5dd5a41717f6a5ff63e8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 20:06:00 2020 +0200

    api.server: Add types and tests on configuration checks



See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/29/ for more details.
Harbormaster completed remote builds in B16491: Diff 15259.Oct 20 2020, 4:16 PM
ardumont retitled this revision from api.server: Add types and tests on configuration checks to Add types and tests on configuration checks.Oct 21 2020, 6:24 PM
ardumont updated this revision to Diff 15297.Oct 22 2020, 11:54 AM
Rebase
ardumont edited the summary of this revision. (Show Details)Oct 22 2020, 11:55 AM
swh-public-ci added a comment.Oct 22 2020, 11:55 AM
Build is green



Patch application report for D4295 (id=15297)



Rebasing onto 97a860997b...



Current branch diff-target is up to date.





Changes applied before test



commit eb868d0e690e9890172b699184bcffb80696fe89
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Oct 20 15:15:52 2020 +0200

    Add tests on current configuration check for cooker instantiation

commit e5e428481c76966cf253d914ca1276c7c9749e69
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 20:06:00 2020 +0200

    api.server: Add types and tests on configuration checks



See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/32/ for more details.
Harbormaster completed remote builds in B16525: Diff 15297.Oct 22 2020, 11:55 AM
vlorentz accepted this revision.Oct 22 2020, 2:34 PM
This revision is now accepted and ready to land.Oct 22 2020, 2:34 PM
Closed by commit rDVAUe5e428481c76: api.server: Add types and tests on configuration checks (authored by ardumont).  ·  Explain WhyOct 22 2020, 2:36 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDVAUe5e428481c76: api.server: Add types and tests on configuration checks.
ardumont added a commit: rDVAUeb868d0e690e: Add tests on current configuration check for cooker instantiation.
Revision Contents
Changeset List
PathSizeCoverage (All)Coverage (Touched)
swh/
vault/
api/
16 lines63%
Loading...
tests/
38 lines100%
Loading...
Diff 15194
View Options
swh/vault/api/server.py
Loading...
View Options
swh/vault/tests/test_server.py
Loading...
About · Developer information · Legal