Page MenuHomeSoftware Heritage

swh.vault: Unify get_vault factory function with other factories
ClosedPublic

Authored by ardumont on Fri, Oct 16, 7:33 PM.

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Oct 16, 7:33 PM

Build has FAILED

Patch application report for D4294 (id=15175)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..3f0225a
Fast-forward
 requirements-test.txt        |  1 +
 swh/vault/__init__.py        | 53 ++++++++++++++++++++++++++----------------
 swh/vault/api/server.py      |  7 ++----
 swh/vault/backend.py         | 13 +++++++----
 swh/vault/tests/conftest.py  | 46 ++++++++++++++++++------------------
 swh/vault/tests/test_init.py | 55 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+), 53 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit 3f0225a0585030d5fe064971164b17e940fce830
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/20/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/20/console

ardumont edited the test plan for this revision. (Show Details)Fri, Oct 16, 7:35 PM
ardumont updated this revision to Diff 15176.Fri, Oct 16, 7:37 PM

Drop the requirements bump on scheduler

Build has FAILED

Patch application report for D4294 (id=15176)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..c062d3a
Fast-forward
 requirements-test.txt        |  1 +
 swh/vault/__init__.py        | 53 ++++++++++++++++++++++++++----------------
 swh/vault/api/server.py      |  7 ++----
 swh/vault/backend.py         | 13 +++++++----
 swh/vault/tests/conftest.py  | 46 ++++++++++++++++++------------------
 swh/vault/tests/test_init.py | 55 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+), 53 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit c062d3ab7ff614bf1ebc3f69ed1de46f77258ba3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/21/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/21/console

ardumont updated this revision to Diff 15177.Fri, Oct 16, 7:44 PM

Drop properly the requirement on swh-scheduler.

Build is green

Patch application report for D4294 (id=15177)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..efd5eb4
Fast-forward
 requirements-test.txt        |  1 +
 swh/vault/__init__.py        | 53 ++++++++++++++++++++++++++----------------
 swh/vault/api/server.py      |  7 ++----
 swh/vault/backend.py         | 13 +++++++----
 swh/vault/tests/conftest.py  | 46 ++++++++++++++++++------------------
 swh/vault/tests/test_init.py | 55 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+), 53 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit efd5eb4dbdb3b451997141b661cb9ae53b8c3c34
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/22/ for more details.

ardumont edited the test plan for this revision. (Show Details)Fri, Oct 16, 7:57 PM
ardumont updated this revision to Diff 15193.Mon, Oct 19, 12:10 PM
ardumont edited the test plan for this revision. (Show Details)

Rebase

Build is green

Patch application report for D4294 (id=15193)

Rebasing onto b5cecff6df...

Current branch diff-target is up to date.
Changes applied before test
commit 8e4026a5e8c9d43832cd3b038b9175f3f4914407
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/24/ for more details.

ardumont added inline comments.Mon, Oct 19, 12:25 PM
swh/vault/api/server.py
229

D4295 for coverage.

vlorentz accepted this revision.Mon, Oct 19, 12:41 PM
This revision is now accepted and ready to land.Mon, Oct 19, 12:41 PM