Page MenuHomeSoftware Heritage

backfill: use get_journal_writer instead if instantiating JournalWriter directly.
ClosedPublic

Authored by vlorentz on Sep 29 2020, 3:55 PM.

Details

Summary

A future version of swh-journal (D4082) will add a mandatory argument to JournalWriter,
whic get_journal_writer sets by default.

Diff Detail

Repository
rDSTO Storage manager
Branch
idx-journal
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16203
Build 24931: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24930: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4081 (id=14400)

Rebasing onto 40997c0506...

Current branch diff-target is up to date.
Changes applied before test
commit 2889766740b7d5f7ab3c53404d47c04b2e70b350
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 29 15:54:55 2020 +0200

    backfill: use get_journal_writer instead if instantiating JournalWriter directly.
    
    A future version of swh-journal will add a mandatory argument to JournalWriter,
    whic get_journal_writer sets by default.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/988/ for more details.

vlorentz retitled this revision from [WIP] backfill: use get_journal_writer instead if instantiating JournalWriter directly. to backfill: use get_journal_writer instead if instantiating JournalWriter directly..Oct 12 2020, 1:57 PM

Build is green

Patch application report for D4081 (id=14940)

Rebasing onto a11d58acb2...

Current branch diff-target is up to date.
Changes applied before test
commit 8a9d46ebd060f4c638e3d53679c8bdb0c5d94593
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 29 15:54:55 2020 +0200

    backfill: use get_journal_writer instead if instantiating JournalWriter directly.
    
    A future version of swh-journal will add a mandatory argument to JournalWriter,
    whic get_journal_writer sets by default.

commit c284f14efdc19c05b317e3438fe043af9ca70a64
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Oct 12 14:57:25 2020 +0200

    migrate_extrinsic_metadata: add support for the new deposit metadata formats introduced in late september.
    
    * https://forge.softwareheritage.org/D4065
    * https://forge.softwareheritage.org/D4105

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1005/ for more details.

ardumont added a subscriber: ardumont.

too much stuff in the diff.

Otherwise, looks fine.

This revision now requires changes to proceed.Oct 12 2020, 4:59 PM

Build is green

Patch application report for D4081 (id=14974)

Rebasing onto b425b5ca48...

Current branch diff-target is up to date.
Changes applied before test
commit 1a9687f0d4f54c41f2c52fdd9dc25c111b2bf908
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 29 15:54:55 2020 +0200

    backfill: use get_journal_writer instead if instantiating JournalWriter directly.
    
    A future version of swh-journal will add a mandatory argument to JournalWriter,
    whic get_journal_writer sets by default.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1007/ for more details.

This revision is now accepted and ready to land.Oct 12 2020, 8:16 PM