core.config: Drop no longer used SWHConfig
ClosedPublic
Actions

Authored by ardumont on Oct 7 2020, 1:49 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T1532: Cleanup deprecated configuration code in swh modules

Commits

rDCORE1657fb827f6d: core.config: Drop no longer used SWHConfig

Summary

All clients of this (loader, lister, indexer...) have migrated to use
load_from_envvar or some derivative (pre-load_from_envvar) of it (deposit)
instead.

$ grep -ri SWHConfig $SWH_ENVIRONMENT_HOME/*/swh/** | grep -v __pycache__
$

Close T1532

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15972
Build 24581: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24580: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 7 2020, 1:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 7 2020, 1:49 PM

Build is green

Patch application report for D4178 (id=14695)

Rebasing onto 82a47667b2...

Current branch diff-target is up to date.

Changes applied before test

commit 1657fb827f6d29254c23bbeaf28aba9c0b2015c0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 7 13:46:53 2020 +0200

    core.config: Drop no longer used SWHConfig
    
    All clients of this (loader, lister, indexer...) have migrated to use
    `load_from_envvar` or some derivative (pre-load_from_envvar) of it (deposit)
    instead.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/90/ for more details.

Harbormaster completed remote builds in B15972: Diff 14695.Oct 7 2020, 1:50 PM

vlorentz accepted this revision.Oct 7 2020, 1:54 PM

This revision is now accepted and ready to land.Oct 7 2020, 1:54 PM

ardumont mentioned this in D4141: lister*: Migrate away from SWHConfig mixin.Oct 7 2020, 2:00 PM

ardumont mentioned this in rDLS2ff92ef40693: lister_base: Drop leftover mixin SWHConfig which is no longer used.Oct 7 2020, 2:01 PM

ardumont edited the summary of this revision. (Show Details)Oct 7 2020, 2:02 PM

ardumont edited the summary of this revision. (Show Details)

Closed by commit rDCORE1657fb827f6d: core.config: Drop no longer used SWHConfig (authored by ardumont). · Explain WhyOct 7 2020, 2:04 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE1657fb827f6d: core.config: Drop no longer used SWHConfig.