Page MenuHomeSoftware Heritage

Rename the `location` variable to `subnet`
ClosedPublic

Authored by olasd on Oct 6 2020, 6:59 PM.

Details

Summary

This makes it clearer what the intent of this variable is, after the
discussion in D4149

Depends on D4163

Test Plan

Need to add a subnet fact to the data of hosts in octocatalog-diff.

Something along the lines of:

sed -i 's/^  location: \(.*\)$/&\n  subnet: \1/' octocatalog-diff/facts/*.yaml

in the puppet-environment repo

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15950
Build 24543: arc lint + arc unit

Event Timeline

yes, intent is clearer!
Thanks.

Need to add a subnet fact to the data of hosts in octocatalog-diff.

Actually unsure of what the end of the sentence means (in regards to octocatalog-diff).

But, yeah, we also need to rename the facts "location" into "subnet" in the provision scripts we have (and Vagrantfile, ...).

This revision is now accepted and ready to land.Oct 6 2020, 7:16 PM

Actually unsure of what the end of the sentence means (in regards to octocatalog-diff).

ok, i got it, the test plan in here and in the next diff explained it.