Page MenuHomeSoftware Heritage

Split subnet-specific settings and deployment-specific settings
ClosedPublic

Authored by olasd on Oct 6 2020, 7:01 PM.

Details

Summary

This introduces a new deployment fact that takes two values, production or staging. This is unfortunately not called environment as this variable name is already used by puppet to mean something else.

This decouples completely which deployment we're doing from what the branch name
of the puppet repo is.

Depends on D4164

Test Plan

Needs to add the new fact to the octocatalog-diff data:

sed -i 's/^  subnet: azure_euwest$/&\n  deployment: production/' octocatalog-diff/facts/*.yaml
sed -i 's/^  subnet: sesi_rocquencourt$/&\n  deployment: production/' octocatalog-diff/facts/*.yaml
sed -i 's/^  subnet: .*staging$/&\n  deployment: staging/' octocatalog-diff/facts/*.yaml

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

looks good to me.

i don't see vagrant in there but i gather that's what you said about making the network part in vagrant a noop or something.

This revision is now accepted and ready to land.Oct 6 2020, 7:22 PM

looks good to me.

i don't see vagrant in there but i gather that's what you said about making the network part in vagrant a noop or something.

the vagrant.yaml was already dedicated to the network configuration of the vagrant environment, so the move to the subnets directory on the previous PR is enough.