Page MenuHomeSoftware Heritage

Fix default value handling in constructor
ClosedPublic

Authored by tenma on Sep 24 2020, 4:32 PM.

Details

Summary

Use a more simple default value and do not identity check against it.

Related to D4017

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15517
Build 23900: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23899: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 24 2020, 4:33 PM

Build is green

Patch application report for D4032 (id=14233)

Rebasing onto 829118a63f...

First, rewinding head to replay your work on top of it...
Applying: Fix default value handling in constructor
Changes applied before test
commit df836004f08238c256189585db320962a4dae507
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Sep 24 14:29:15 2020 +0200

    Fix default value handling in constructor
    
    Use a more simple default value and do not identity check against it.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/974/ for more details.

This revision was landed with ongoing or failed builds.Sep 24 2020, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D4032 (id=14242)

Rebasing onto 829118a63f...

Current branch diff-target is up to date.
Changes applied before test
commit 96be9bd4b84a7d7fd82ffca9a4b03f261bf67fec
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Sep 24 14:29:15 2020 +0200

    Fix default value handling in constructor
    
    Use a more simple default value and do not identity check against it.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/978/ for more details.