Differential D4032

Fix default value handling in constructor
ClosedPublic
Actions

Authored by tenma on Sep 24 2020, 4:32 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTO96be9bd4b84a: Fix default value handling in constructor

Summary

Use a more simple default value and do not identity check against it.

Related to D4017

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tenma created this revision.Sep 24 2020, 4:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 24 2020, 4:32 PM

olasd accepted this revision.Sep 24 2020, 4:33 PM

This revision is now accepted and ready to land.Sep 24 2020, 4:33 PM

tenma added a child revision: D4033: Improve typing of the buffering interface.Sep 24 2020, 4:35 PM

Build is green

Patch application report for D4032 (id=14233)

Rebasing onto 829118a63f...

First, rewinding head to replay your work on top of it...
Applying: Fix default value handling in constructor

Changes applied before test

commit df836004f08238c256189585db320962a4dae507
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Sep 24 14:29:15 2020 +0200

    Fix default value handling in constructor
    
    Use a more simple default value and do not identity check against it.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/974/ for more details.

Harbormaster completed remote builds in B15508: Diff 14233.Sep 24 2020, 4:37 PM

Rebase

This revision was landed with ongoing or failed builds.Sep 24 2020, 6:34 PM

Closed by commit rDSTO96be9bd4b84a: Fix default value handling in constructor (authored by tenma, committed by olasd). · Explain Why

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO96be9bd4b84a: Fix default value handling in constructor.

Build is green

Patch application report for D4032 (id=14242)

Rebasing onto 829118a63f...

Current branch diff-target is up to date.

Changes applied before test

commit 96be9bd4b84a7d7fd82ffca9a4b03f261bf67fec
Author: tenma <tenma+swh@mailbox.org>
Date:   Thu Sep 24 14:29:15 2020 +0200

    Fix default value handling in constructor
    
    Use a more simple default value and do not identity check against it.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/978/ for more details.

Harbormaster completed remote builds in B15517: Diff 14242.Sep 24 2020, 6:39 PM