Page MenuHomeSoftware Heritage

common/origin_save: Fix save request task running status reporting
ClosedPublic

Authored by anlambert on Sep 22 2020, 12:38 PM.

Details

Summary

It was broken since the migration to origin visit statuses in swh data model.

Closes T2614

Depends on D4004

Diff Detail

Repository
rDWAPPS Web applications
Branch
save-request-running-status
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15399
Build 23720: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23719: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4005 (id=14125)

Could not rebase; Attempt merge onto c45a6af2f7...

Updating c45a6af2..443ceecb
Fast-forward
 cypress/integration/origin-save.spec.js            |  4 +-
 swh/web/api/views/origin_save.py                   |  4 +-
 swh/web/assets/src/bundles/save/index.js           |  4 +-
 .../0007_save_request_task_status_fix_typo.py      | 43 ++++++++++++++++++++++
 swh/web/common/models.py                           |  4 +-
 swh/web/common/origin_save.py                      | 22 +++++++----
 swh/web/tests/api/views/test_origin_save.py        |  6 +--
 swh/web/tests/common/test_origin_save.py           | 31 ++++++++++------
 swh/web/tests/misc/test_metrics.py                 |  4 +-
 9 files changed, 89 insertions(+), 33 deletions(-)
 create mode 100644 swh/web/common/migrations/0007_save_request_task_status_fix_typo.py
Changes applied before test
commit 443ceecba5f10573c2c4bb25e796c615edb17c0a
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Sep 21 17:36:05 2020 +0200

    common/origin_save: Fix save request task running status reporting
    
    It was broken since the migration to origin visit statuses in swh data model.
    
    Closes T2614

commit e25f6fb0ec5eb6433888dfef64686b30d49dc2c0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Sep 21 15:58:42 2020 +0200

    origin_save: Fix typo in a save task status (s/succeed/succeeded/)
    
    Closes T2615

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/381/ for more details.

This revision is now accepted and ready to land.Sep 22 2020, 1:50 PM

Build is green

Patch application report for D4005 (id=14134)

Could not rebase; Attempt merge onto 1694f6b03f...

Updating 1694f6b0..baaefd62
Fast-forward
 cypress/integration/origin-save.spec.js            |  4 +-
 swh/web/api/views/origin_save.py                   |  4 +-
 swh/web/assets/src/bundles/save/index.js           |  4 +-
 .../0007_save_request_task_status_fix_typo.py      | 43 ++++++++++++++++++++++
 swh/web/common/models.py                           |  4 +-
 swh/web/common/origin_save.py                      | 22 +++++++----
 swh/web/tests/api/views/test_origin_save.py        |  6 +--
 swh/web/tests/common/test_origin_save.py           | 31 ++++++++++------
 swh/web/tests/misc/test_metrics.py                 |  4 +-
 9 files changed, 89 insertions(+), 33 deletions(-)
 create mode 100644 swh/web/common/migrations/0007_save_request_task_status_fix_typo.py
Changes applied before test
commit baaefd62d8c528036de46a5f4ad41730a5ae4b5d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Sep 21 17:36:05 2020 +0200

    common/origin_save: Fix save request task running status reporting
    
    It was broken since the migration to origin visit statuses in swh data model.
    
    Closes T2614

commit c53756359a43340d08d96a90c05a5b49dec52dbb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Sep 21 15:58:42 2020 +0200

    origin_save: Fix typo in a save task status (s/succeed/succeeded/)
    
    Closes T2615

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/383/ for more details.