Differential D4004

)
ClosedPublic
Actions

Authored by anlambert on Sep 22 2020, 12:30 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Maniphest Tasks

T2615: Web UI: typo in success status for save code now requests: "succeed" -> "succeeded"

Commits

rDWAPPSc53756359a43: origin_save: Fix typo in a save task status (s/succeed/succeeded/)

Summary

Closes T2615

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 22 2020, 12:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 22 2020, 12:30 PM

Build is green

Patch application report for D4004 (id=14124)

Rebasing onto c45a6af2f7...

Current branch diff-target is up to date.

Changes applied before test

commit e25f6fb0ec5eb6433888dfef64686b30d49dc2c0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Sep 21 15:58:42 2020 +0200

    origin_save: Fix typo in a save task status (s/succeed/succeeded/)
    
    Closes T2615

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/380/ for more details.

Harbormaster completed remote builds in B15390: Diff 14124.Sep 22 2020, 12:37 PM

anlambert added a child revision: D4005: common/origin_save: Fix save request task running status reporting.Sep 22 2020, 12:38 PM

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

This revision is now accepted and ready to land.Sep 22 2020, 12:59 PM

In D4004#98985, @zack wrote:

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

Oh right, it changes a returned value. I will send a mail during the afternoon.

Rebase

Build is green

Patch application report for D4004 (id=14132)

Rebasing onto 1694f6b03f...

Current branch diff-target is up to date.

Changes applied before test

commit c53756359a43340d08d96a90c05a5b49dec52dbb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Sep 21 15:58:42 2020 +0200

    origin_save: Fix typo in a save task status (s/succeed/succeeded/)
    
    Closes T2615

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/382/ for more details.

Harbormaster completed remote builds in B15397: Diff 14132.Sep 22 2020, 1:58 PM

In D4004#99008, @anlambert wrote:

In D4004#98985, @zack wrote:

Caveat: as this results in an API change (I think), it should be announced on the swh-devel mailing list before deployment.

Oh right, it changes a returned value. I will send a mail during the afternoon.