Details
Details
- Reviewers
seirl - Group Reviewers
Reviewers - Commits
- rDGRPH271274d4aa9a: docs: replace deprecated "SWH PID" naming with "SWHID"
rDGRPHee61a2492f6f: tools: replace deprecated "SWH PID" naming with "SWHID"
rDGRPH1677b8e600fb: graph: replace deprecated "SWH PID" naming with "SWHID"
rDGRPH85cec41c71a3: java: replace deprecated "SWH PID" naming with "SWHID"
Diff Detail
Diff Detail
- Repository
- rDGRPH Compressed graph representation
- Branch
- feature/pid-to-swhid-v2
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15336 Build 23619: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 23618: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3990 (id=14068)
Rebasing onto bc5614a2c6...
Current branch diff-target is up to date.
Changes applied before test
commit 661ca912575680fdd6726913ddab37428798199c Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 15:24:30 2020 +0200 docs: replace deprecated "SWH PID" naming with "SWHID" commit 9398a78cdb2d3f0c1ee8aedeabef9fe4f8385a7f Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 15:21:07 2020 +0200 tools: replace deprecated "SWH PID" naming with "SWHID" commit 4df9c42a99e004ca80f133658625c2ab1b6035eb Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 15:03:15 2020 +0200 graph: replace deprecated "SWH PID" naming with "SWHID" commit 95a88f685dfc9c2d5ddcd2506288910d01695777 Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 14:43:37 2020 +0200 java: replace deprecated "SWH PID" naming with "SWHID"
See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/39/ for more details.
java/src/main/java/org/softwareheritage/graph/server/Endpoint.java | ||
---|---|---|
45 | Maybe rename it to swhids? |
java/src/main/java/org/softwareheritage/graph/server/Endpoint.java | ||
---|---|---|
45 | Yes, having the first letter of variables lowercase is important. |
Comment Actions
Build is green
Patch application report for D3990 (id=14071)
Rebasing onto bc5614a2c6...
Current branch diff-target is up to date.
Changes applied before test
commit 271274d4aa9ae36670b146955d67ca2b01eed19c Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 15:24:30 2020 +0200 docs: replace deprecated "SWH PID" naming with "SWHID" commit ee61a2492f6f1f3f08aaa918e7b71884dc77584f Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 15:21:07 2020 +0200 tools: replace deprecated "SWH PID" naming with "SWHID" commit 1677b8e600fbbfe5f6686f0aea6bebd681fddcc9 Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 15:03:15 2020 +0200 graph: replace deprecated "SWH PID" naming with "SWHID" commit 85cec41c71a3c11c8f53c2ce8b5b778857afe764 Author: Thibault Allançon <haltode@gmail.com> Date: Fri Sep 18 14:43:37 2020 +0200 java: replace deprecated "SWH PID" naming with "SWHID"
See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/40/ for more details.