model: remove deprecated and unused PID methods
ClosedPublic
Actions

Authored by haltode on Sep 18 2020, 4:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODe0b4b9464ae4: model: remove deprecated and unused PID methods

Summary

Use the new SWHID naming convention instead of SWH PID.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Sep 18 2020, 4:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 18 2020, 4:51 PM

ardumont accepted this revision.Sep 18 2020, 4:51 PM

This revision is now accepted and ready to land.Sep 18 2020, 4:51 PM

Build is green

Patch application report for D3995 (id=14080)

Rebasing onto a27371850a...

First, rewinding head to replay your work on top of it...
Applying: model: remove deprecated and unused PID methods

Changes applied before test

commit cf38b449fbf4194957453c44f00aa05194c6c467
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 16:49:15 2020 +0200

    model: remove deprecated and unused PID methods
    
    Use the new SWHID naming convention instead of SWH PID.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/135/ for more details.

Harbormaster completed remote builds in B15347: Diff 14080.Sep 18 2020, 4:52 PM

Thanks.

I recall @anlambert already cleaned up a lot of previous code.
That and your recent work on swh.graph, i think we are good to remove those now.

Related (and already merged) diffs:

swh-web-client: D3982
swh-graph: D3990
swh-dataset: D3994

So yeah there should be no more occurrences of these in the codebase now! :)

Rebase on master.

Build is green

Patch application report for D3995 (id=14082)

Rebasing onto a27371850a...

Current branch diff-target is up to date.

Changes applied before test

commit e0b4b9464ae410abe91a3ed9409537967e3ebc72
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 16:49:15 2020 +0200

    model: remove deprecated and unused PID methods
    
    Use the new SWHID naming convention instead of SWH PID.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/136/ for more details.

Harbormaster completed remote builds in B15349: Diff 14082.Sep 18 2020, 5:07 PM

Closed by commit rDMODe0b4b9464ae4: model: remove deprecated and unused PID methods (authored by haltode). · Explain WhySep 18 2020, 5:08 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDMODe0b4b9464ae4: model: remove deprecated and unused PID methods.