Replace deprecated "SWH PID" naming with "SWHID"
ClosedPublic
Actions

Authored by haltode on Sep 18 2020, 3:27 PM.

Details

Reviewers

seirl

Group Reviewers

Reviewers

Commits

rDGRPH271274d4aa9a: docs: replace deprecated "SWH PID" naming with "SWHID"
rDGRPHee61a2492f6f: tools: replace deprecated "SWH PID" naming with "SWHID"
rDGRPH1677b8e600fb: graph: replace deprecated "SWH PID" naming with "SWHID"
rDGRPH85cec41c71a3: java: replace deprecated "SWH PID" naming with "SWHID"

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Sep 18 2020, 3:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 18 2020, 3:27 PM

Build is green

Patch application report for D3990 (id=14068)

Rebasing onto bc5614a2c6...

Current branch diff-target is up to date.

Changes applied before test

commit 661ca912575680fdd6726913ddab37428798199c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 15:24:30 2020 +0200

    docs: replace deprecated "SWH PID" naming with "SWHID"

commit 9398a78cdb2d3f0c1ee8aedeabef9fe4f8385a7f
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 15:21:07 2020 +0200

    tools: replace deprecated "SWH PID" naming with "SWHID"

commit 4df9c42a99e004ca80f133658625c2ab1b6035eb
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 15:03:15 2020 +0200

    graph: replace deprecated "SWH PID" naming with "SWHID"

commit 95a88f685dfc9c2d5ddcd2506288910d01695777
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 14:43:37 2020 +0200

    java: replace deprecated "SWH PID" naming with "SWHID"

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/39/ for more details.

Harbormaster completed remote builds in B15336: Diff 14068.Sep 18 2020, 3:29 PM

haltode added inline comments.Sep 18 2020, 3:43 PM

java/src/main/java/org/softwareheritage/graph/server/Endpoint.java
44	Maybe rename it to `swhids`?

seirl accepted this revision.Sep 18 2020, 3:52 PM

seirl added a subscriber: seirl.

seirl added inline comments.

java/src/main/java/org/softwareheritage/graph/server/Endpoint.java
44	Yes, having the first letter of variables lowercase is important.

This revision is now accepted and ready to land.Sep 18 2020, 3:52 PM

Rename SWHIDS variable to swhids.

haltode marked an inline comment as done.Sep 18 2020, 4:07 PM

Build is green

Patch application report for D3990 (id=14071)

Rebasing onto bc5614a2c6...

Current branch diff-target is up to date.

Changes applied before test

commit 271274d4aa9ae36670b146955d67ca2b01eed19c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 15:24:30 2020 +0200

    docs: replace deprecated "SWH PID" naming with "SWHID"

commit ee61a2492f6f1f3f08aaa918e7b71884dc77584f
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 15:21:07 2020 +0200

    tools: replace deprecated "SWH PID" naming with "SWHID"

commit 1677b8e600fbbfe5f6686f0aea6bebd681fddcc9
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 15:03:15 2020 +0200

    graph: replace deprecated "SWH PID" naming with "SWHID"

commit 85cec41c71a3c11c8f53c2ce8b5b778857afe764
Author: Thibault Allançon <haltode@gmail.com>
Date:   Fri Sep 18 14:43:37 2020 +0200

    java: replace deprecated "SWH PID" naming with "SWHID"

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/40/ for more details.

Harbormaster completed remote builds in B15339: Diff 14071.Sep 18 2020, 4:08 PM

Closed by commit rDGRPH85cec41c71a3: java: replace deprecated "SWH PID" naming with "SWHID" (authored by haltode). · Explain WhySep 18 2020, 4:12 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDGRPH85cec41c71a3: java: replace deprecated "SWH PID" naming with "SWHID".

haltode added a commit: rDGRPH1677b8e600fb: graph: replace deprecated "SWH PID" naming with "SWHID".

haltode added a commit: rDGRPHee61a2492f6f: tools: replace deprecated "SWH PID" naming with "SWHID".

haltode added a commit: rDGRPH271274d4aa9a: docs: replace deprecated "SWH PID" naming with "SWHID".

haltode mentioned this in D3506: rename from "PID" to "SWHID" terminology everywhere.Sep 18 2020, 4:15 PM

haltode mentioned this in D3995: model: remove deprecated and unused PID methods.Sep 18 2020, 4:55 PM