Differential D3703

storage*: content_missing: Unify and type remaining existing endpoints
ClosedPublic
Actions

Authored by ardumont on Aug 4 2020, 6:48 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2517: Add remaining missing types to swh.storage.interface

Commits

rDSTOb62afbbbdd95: storage*: content_missing: Unify and type remaining existing endpoints

Summary

This updates the docstrings as well

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14282
Build 21965: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21964: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 4 2020, 6:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2020, 6:48 PM

Build has FAILED

Patch application report for D3703 (id=13036)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..c0c8f845
Fast-forward
 swh/storage/cassandra/storage.py | 46 +++++++++++++++---------
 swh/storage/in_memory.py         | 50 ++++++++++++++++----------
 swh/storage/interface.py         | 78 +++++++++++++++++++++-------------------
 swh/storage/storage.py           | 50 +++++++++++++++-----------
 4 files changed, 132 insertions(+), 92 deletions(-)

Changes applied before test

commit c0c8f845dbf5f9812688f91431a9d4972b575065
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit fa7fb03181f5fb242b486543a6c2b6e9c345a81d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit bc32f7ea2f1046920dad0a101da463fd91bf6692
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit 6d15e4d4c2544c36dac8eb6d12cbc17cdf401e10
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 2925f7176a0f6ede8242c6507a69a00ce313cca2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/673/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/673/console

Harbormaster failed remote builds in B14279: Diff 13036!Aug 4 2020, 7:11 PM

Rebase

Build is green

Patch application report for D3703 (id=13039)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..b62afbbb
Fast-forward
 swh/storage/cassandra/storage.py | 46 +++++++++++++++---------
 swh/storage/in_memory.py         | 52 +++++++++++++++++----------
 swh/storage/interface.py         | 78 +++++++++++++++++++++-------------------
 swh/storage/storage.py           | 50 +++++++++++++++-----------
 4 files changed, 134 insertions(+), 92 deletions(-)

Changes applied before test

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/676/ for more details.

Harbormaster completed remote builds in B14282: Diff 13039.Aug 4 2020, 9:51 PM

vlorentz accepted this revision.Aug 5 2020, 9:00 AM

This revision is now accepted and ready to land.Aug 5 2020, 9:00 AM

Closed by commit rDSTOb62afbbbdd95: storage*: content_missing: Unify and type remaining existing endpoints (authored by ardumont). · Explain WhyAug 5 2020, 11:54 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOb62afbbbdd95: storage*: content_missing: Unify and type remaining existing endpoints.

ardumont added a task: T2517: Add remaining missing types to swh.storage.interface.Aug 5 2020, 1:12 PM

ardumont removed a task: T645: Type swh-storage endpoints with swh.model objects.