Differential D3647

service: Migrate to latest origin_visit_get api change
ClosedPublic
Actions

Authored by ardumont on Jul 29 2020, 8:17 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDWAPPSb712b2679eae: service: Migrate to latest origin_visit_get api change

Summary

As usual, for now, I'm keeping the existing behavior.
I'm not refactoring the webapp as well.

Related to T645

Test Plan

tox
(failing, needs storage release > 0.11.6)

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14074
Build 21610: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21609: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 29 2020, 8:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 29 2020, 8:17 PM

ardumont edited the test plan for this revision. (Show Details)Jul 29 2020, 8:18 PM

ardumont mentioned this in D3627: storage*: origin_visit_get(...) -> PagedResult[OriginVisit].Jul 29 2020, 8:25 PM

Build has FAILED

Patch application report for D3647 (id=12838)

Could not rebase; Attempt merge onto c61a7a2ffb...

Updating c61a7a2f..b712b267
Fast-forward
 swh/web/common/service.py   | 32 +++++++++++++++++++-------------
 swh/web/tests/conftest.py   | 29 ++++++++++++++++++++---------
 swh/web/tests/strategies.py |  5 +++--
 3 files changed, 42 insertions(+), 24 deletions(-)

Changes applied before test

commit b712b2679eaefcaa9bb7b06dfee4415be8bb7dd5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 29 20:13:10 2020 +0200

    service: Migrate to latest origin_visit_get api change
    
    Related to T645

commit ac847788bf041a31728cb255d1bf4bcb9e5141b5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 29 20:15:02 2020 +0200

    Fix according to recent type change in storage

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/284/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/284/console

Harbormaster failed remote builds in B14074: Diff 12838!Jul 29 2020, 8:34 PM

ardumont edited the summary of this revision. (Show Details)Jul 30 2020, 9:45 AM

vlorentz accepted this revision.Jul 30 2020, 10:18 AM

This revision is now accepted and ready to land.Jul 30 2020, 10:18 AM

Build is green

Patch application report for D3647 (id=12838)

Rebasing onto ac847788bf...

Current branch diff-target is up to date.

Changes applied before test

commit b712b2679eaefcaa9bb7b06dfee4415be8bb7dd5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 29 20:13:10 2020 +0200

    service: Migrate to latest origin_visit_get api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/285/ for more details.

Harbormaster completed remote builds in B14074: Diff 12838.Jul 30 2020, 5:05 PM

Closed by commit rDWAPPSb712b2679eae: service: Migrate to latest origin_visit_get api change (authored by ardumont). · Explain WhyJul 30 2020, 5:06 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPSb712b2679eae: service: Migrate to latest origin_visit_get api change.