Page MenuHomeSoftware Heritage

service: Migrate to latest origin_visit_get api change
ClosedPublic

Authored by ardumont on Wed, Jul 29, 8:17 PM.

Details

Summary

As usual, for now, I'm keeping the existing behavior.
I'm not refactoring the webapp as well.

Related to T645

Test Plan

tox
(failing, needs storage release > 0.11.6)

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Jul 29, 8:17 PM
ardumont edited the test plan for this revision. (Show Details)Wed, Jul 29, 8:18 PM

Build has FAILED

Patch application report for D3647 (id=12838)

Could not rebase; Attempt merge onto c61a7a2ffb...

Updating c61a7a2f..b712b267
Fast-forward
 swh/web/common/service.py   | 32 +++++++++++++++++++-------------
 swh/web/tests/conftest.py   | 29 ++++++++++++++++++++---------
 swh/web/tests/strategies.py |  5 +++--
 3 files changed, 42 insertions(+), 24 deletions(-)
Changes applied before test
commit b712b2679eaefcaa9bb7b06dfee4415be8bb7dd5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 29 20:13:10 2020 +0200

    service: Migrate to latest origin_visit_get api change
    
    Related to T645

commit ac847788bf041a31728cb255d1bf4bcb9e5141b5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 29 20:15:02 2020 +0200

    Fix according to recent type change in storage

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/284/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/284/console

ardumont edited the summary of this revision. (Show Details)Thu, Jul 30, 9:45 AM
vlorentz accepted this revision.Thu, Jul 30, 10:18 AM
This revision is now accepted and ready to land.Thu, Jul 30, 10:18 AM

Build is green

Patch application report for D3647 (id=12838)

Rebasing onto ac847788bf...

Current branch diff-target is up to date.
Changes applied before test
commit b712b2679eaefcaa9bb7b06dfee4415be8bb7dd5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 29 20:13:10 2020 +0200

    service: Migrate to latest origin_visit_get api change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/285/ for more details.