Page MenuHomeSoftware Heritage
Differential D3640

Add type annotations on get_storage.
ClosedPublic
Actions

Authored by vlorentz on Jul 29 2020, 3:13 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO8cf6efa2e62d: Add type annotations on get_storage.
Summary

The main goal of this commit is to add '-> StorageInterface', so all storage
users automatically get type-checked.

But mypy was whining about the multiple imports, so this commit also
deduplicates the import statements as a side-effect.

Diff Detail

Repository
rDSTO Storage manager
Branch
get_storage-type
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14052
Build 21573: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 21572: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 29 2020, 3:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 29 2020, 3:13 PM
ardumont added a subscriber: ardumont.Jul 29 2020, 3:14 PM
ardumont added inline comments.
swh/storage/__init__.py
24

But is this true though?

at least filter/buffer/retry are not per say StorageInterface, aren't they?

ardumont added inline comments.Jul 29 2020, 3:16 PM
swh/storage/__init__.py
24

I'm doing it heh but i keep having that voice raising in my head saying "lies" ;)

ardumont added inline comments.Jul 29 2020, 3:18 PM
swh/storage/__init__.py
19

What happened to pipeline?
It is used!

[1] https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/data/defaults.yaml$1167

swh-public-ci added a comment.Jul 29 2020, 3:20 PM

Build is green

Patch application report for D3640 (id=12820)

Rebasing onto 21b77304a0...

First, rewinding head to replay your work on top of it...
Applying: Add type annotations on get_storage.
Changes applied before test
commit fa45a9b83c0f61547652cfb943441524633e02db
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 29 15:13:04 2020 +0200

    Add type annotations on get_storage.
    
    The main goal of this commit is to add '-> StorageInterface', so all storage
    users automatically get type-checked.
    
    But mypy was whining about the multiple imports, so this commit also
    deduplicates the import statements as a side-effect.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/599/ for more details.

Harbormaster completed remote builds in B14051: Diff 12820.Jul 29 2020, 3:20 PM
vlorentz added inline comments.Jul 29 2020, 3:33 PM
swh/storage/__init__.py
19

I didn't remove it from get_storage.

24

They behave differently, but their signatures are the same afaik

ardumont added inline comments.Jul 29 2020, 3:53 PM
swh/storage/__init__.py
19

ah yeah, thanks ;)

24

yes, indeed.
just raising this "concern" to someone else ;)

64

well, might as well type it as well to return a StorageInterface.

vlorentz updated this revision to Diff 12821.Jul 29 2020, 4:05 PM

add type for get_storage_pipeline.

swh-public-ci added a comment.Jul 29 2020, 4:13 PM

Build is green

Patch application report for D3640 (id=12821)

Rebasing onto 21b77304a0...

First, rewinding head to replay your work on top of it...
Applying: Add type annotations on get_storage.
Changes applied before test
commit 796cb00681ffca68f5734ea6f0245af3e333e7eb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jul 29 15:13:04 2020 +0200

    Add type annotations on get_storage.
    
    The main goal of this commit is to add '-> StorageInterface', so all storage
    users automatically get type-checked.
    
    But mypy was whining about the multiple imports, so this commit also
    deduplicates the import statements as a side-effect.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/600/ for more details.

Harbormaster completed remote builds in B14052: Diff 12821.Jul 29 2020, 4:13 PM
ardumont accepted this revision.Jul 29 2020, 4:21 PM

Thanks.

This revision is now accepted and ready to land.Jul 29 2020, 4:21 PM
vlorentz updated this revision to Diff 12851.Jul 30 2020, 1:53 PM

rebase

This revision was landed with ongoing or failed builds.Jul 30 2020, 1:53 PM
Closed by commit rDSTO8cf6efa2e62d: Add type annotations on get_storage. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTO8cf6efa2e62d: Add type annotations on get_storage..
swh-public-ci added a comment.Jul 30 2020, 2:02 PM

Build is green

Patch application report for D3640 (id=12851)

Rebasing onto 8cf6efa2e6...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-622-D3640.
Changes applied before test



See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/622/ for more details.
Harbormaster completed remote builds in B14087: Diff 12851.Jul 30 2020, 2:02 PM
Revision Contents
Changeset List
PathSizeCoverage (All)Coverage (Touched)
swh/
storage/
57 lines96%
Loading...
tests/
6 lines87%
Loading...
7 lines98%
Loading...
Diff 12821
View Options
swh/storage/__init__.py
Loading...
View Options
swh/storage/tests/test_kafka_writer.py
Loading...
View Options
swh/storage/tests/test_replay.py
Loading...
About · Developer information · Legal