Differential D3571

test_storage: snapshot: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 3:58 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTOcf80d3c29d7a: test_storage: snapshot: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13800
Build 21148: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21147: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 3:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 3:58 PM

Build is green

Patch application report for D3571 (id=12574)

Could not rebase; Attempt merge onto 1c1bef91e1...

Updating 1c1bef91..a6b0695a
Fast-forward
 swh/storage/tests/test_storage.py | 245 ++++++++++++++++++++------------------
 1 file changed, 129 insertions(+), 116 deletions(-)

Changes applied before test

commit a6b0695a7d915ca450396e9b718d334e347b1d06
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:58:35 2020 +0200

    test_storage: snapshot: Use data model object
    
    Related to T2494

commit 4f1017173b98cbc742a45d1b44ea5716dcab29a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:36:05 2020 +0200

    test_storage: origin_visit/origin_visit_status: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/501/ for more details.

Harbormaster completed remote builds in B13799: Diff 12574.Jul 20 2020, 4:05 PM

Migrate remaining snapshot tests

Build is green

Patch application report for D3571 (id=12575)

Could not rebase; Attempt merge onto 1c1bef91e1...

Updating 1c1bef91..cf80d3c2
Fast-forward
 swh/storage/tests/test_storage.py | 400 ++++++++++++++++++++------------------
 1 file changed, 214 insertions(+), 186 deletions(-)

Changes applied before test

commit cf80d3c29d7a7f2094570c14478fcc93dd995a12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:58:35 2020 +0200

    test_storage: snapshot: Use data model object
    
    Related to T2494

commit 4f1017173b98cbc742a45d1b44ea5716dcab29a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 15:36:05 2020 +0200

    test_storage: origin_visit/origin_visit_status: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/502/ for more details.

Harbormaster completed remote builds in B13800: Diff 12575.Jul 20 2020, 4:28 PM

vlorentz accepted this revision.Jul 20 2020, 6:06 PM

This revision is now accepted and ready to land.Jul 20 2020, 6:06 PM

Closed by commit rDSTOcf80d3c29d7a: test_storage: snapshot: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 6:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOcf80d3c29d7a: test_storage: snapshot: Use data model object.