Differential D3568

test_storage: origin: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 2:33 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTOcdf6f580817c: test_storage: origin: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13794
Build 21138: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21137: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 2:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 2:33 PM

Build is green

Patch application report for D3568 (id=12568)

Rebasing onto bbdd7ed48d...

Current branch diff-target is up to date.

Changes applied before test

commit 49dc2fc9c370e5f2046a7eea934aa5b5fac79308
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 14:34:24 2020 +0200

    test_storage: origin: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/497/ for more details.

Harbormaster completed remote builds in B13793: Diff 12568.Jul 20 2020, 2:40 PM

Drop dead test conditional

Build is green

Patch application report for D3568 (id=12569)

Rebasing onto bbdd7ed48d...

Current branch diff-target is up to date.

Changes applied before test

commit cdf6f580817cd6b3c1995a2d76eb5470b1f1abc7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 14:34:24 2020 +0200

    test_storage: origin: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/498/ for more details.

Harbormaster completed remote builds in B13794: Diff 12569.Jul 20 2020, 2:58 PM

vlorentz accepted this revision.Jul 20 2020, 3:14 PM

This revision is now accepted and ready to land.Jul 20 2020, 3:14 PM

Closed by commit rDSTOcdf6f580817c: test_storage: origin: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 3:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOcdf6f580817c: test_storage: origin: Use data model object.