Differential D3564

test_storage: revision: Use data model object
ClosedPublic
Actions

Authored by ardumont on Jul 20 2020, 12:55 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTOa17c4128d809: test_storage: revision: Use data model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13781
Build 21119: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 21118: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 20 2020, 12:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2020, 12:55 PM

Build has FAILED

Patch application report for D3564 (id=12558)

Rebasing onto 87b1070b8f...

Current branch diff-target is up to date.

Changes applied before test

commit bc96aeef9d87dd4cb2c26508b65a3604f174b018
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 12:55:46 2020 +0200

    test_storage: revision: Use data model object
    
    Related to T2494

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/493/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/493/console

Harbormaster failed remote builds in B13781: Diff 12558!Jul 20 2020, 12:56 PM

Fix a helper function migrated entirely too soon (need to deal with release first in another diff)
+ rebase

Build is green

Patch application report for D3564 (id=12559)

Rebasing onto 03c6e1552c...

Current branch diff-target is up to date.

Changes applied before test

commit a17c4128d809791fe2c96db7b8a278ba54342300
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 20 12:55:46 2020 +0200

    test_storage: revision: Use data model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/494/ for more details.

Harbormaster completed remote builds in B13783: Diff 12559.Jul 20 2020, 1:10 PM

vlorentz accepted this revision.Jul 20 2020, 1:27 PM

This revision is now accepted and ready to land.Jul 20 2020, 1:27 PM

Closed by commit rDSTOa17c4128d809: test_storage: revision: Use data model object (authored by ardumont). · Explain WhyJul 20 2020, 1:38 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOa17c4128d809: test_storage: revision: Use data model object.