Differential D3547

tests: Check against snapshot model object
ClosedPublic
Actions

Authored by ardumont on Jul 17 2020, 11:14 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDLDHG6a3c89a93877: tests: Check against snapshot model object

Summary

Related to T2494

(hopefully the last one?)

Test Plan

tox

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 17 2020, 11:14 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 17 2020, 11:14 AM

Build is green

Patch application report for D3547 (id=12500)

Rebasing onto 786f8caa37...

Current branch diff-target is up to date.

Changes applied before test

commit 6a3c89a938779be7647092009f62db936c92766f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 17 11:14:08 2020 +0200

    tests: Check against snapshot model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/34/ for more details.

Harbormaster completed remote builds in B13724: Diff 12500.Jul 17 2020, 11:16 AM

ardumont mentioned this in D3543: check_snapshot: Drop accepting using dict for snapshot comparison.Jul 17 2020, 11:16 AM

douardda accepted this revision.Jul 17 2020, 11:17 AM

This revision is now accepted and ready to land.Jul 17 2020, 11:17 AM

Closed by commit rDLDHG6a3c89a93877: tests: Check against snapshot model object (authored by ardumont). · Explain WhyJul 17 2020, 11:25 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDHG6a3c89a93877: tests: Check against snapshot model object.

Revision Contents
Changeset List

Path

Size

swh/

loader/

mercurial/

tests/

test_loader.py

78 lines

Diff 12509

View Options

swh/loader/mercurial/tests/test_loader.py

tests: Check against snapshot model objectClosedPublicActions