Differential D3537

test_cran: Check against snapshot model object
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 5:41 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDLDBASEa0a131142843: test_cran: Check against snapshot model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13704
Build 20997: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20996: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 16 2020, 5:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 5:41 PM

Build is green

Patch application report for D3537 (id=12480)

Could not rebase; Attempt merge onto d72fdf0448...

Updating d72fdf0..ac0dc24
Fast-forward
 swh/loader/package/archive/tests/test_archive.py | 40 ++++++++--------
 swh/loader/package/cran/tests/test_cran.py       | 42 +++++++++--------
 swh/loader/package/debian/tests/test_debian.py   | 58 ++++++++++++------------
 3 files changed, 72 insertions(+), 68 deletions(-)

Changes applied before test

commit ac0dc24947f5d0ea72d247296f81b56714349a0f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:41:46 2020 +0200

    test_cran: Check against snapshot model object
    
    Related to T2494

commit 767971963d7b4832cc78011d77e71a8ca002aa22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:38:30 2020 +0200

    test_debian: Check against snapshot model object
    
    Related to T2494

commit d4cce1aedda27222ace4853faae67b740a22242e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:01:45 2020 +0200

    test_archive: Check against snapshot model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/168/ for more details.

Harbormaster completed remote builds in B13704: Diff 12480.Jul 16 2020, 5:43 PM

anlambert accepted this revision.Jul 16 2020, 5:50 PM

This revision is now accepted and ready to land.Jul 16 2020, 5:50 PM

Refactor common snapshot

Build is green

Patch application report for D3537 (id=12484)

Could not rebase; Attempt merge onto d72fdf0448...

Updating d72fdf0..a0a1311
Fast-forward
 swh/loader/package/archive/tests/test_archive.py | 40 ++++++++--------
 swh/loader/package/cran/tests/test_cran.py       | 45 ++++++++----------
 swh/loader/package/debian/tests/test_debian.py   | 58 ++++++++++++------------
 3 files changed, 68 insertions(+), 75 deletions(-)

Changes applied before test

commit a0a131142843e9fc059f15fe2a22bdb7ecbccaad
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:41:46 2020 +0200

    test_cran: Check against snapshot model object
    
    Related to T2494

commit 767971963d7b4832cc78011d77e71a8ca002aa22
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:38:30 2020 +0200

    test_debian: Check against snapshot model object
    
    Related to T2494

commit d4cce1aedda27222ace4853faae67b740a22242e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:01:45 2020 +0200

    test_archive: Check against snapshot model object
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/170/ for more details.

Harbormaster completed remote builds in B13708: Diff 12484.Jul 16 2020, 6:12 PM

Closed by commit rDLDBASEa0a131142843: test_cran: Check against snapshot model object (authored by ardumont). · Explain WhyJul 16 2020, 6:13 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEa0a131142843: test_cran: Check against snapshot model object.