Differential D3523

test_revision_bw_compat: Use revision model object
ClosedPublic
Actions

Authored by ardumont on Jul 16 2020, 12:08 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2494: tests: Use data model objects within tests (drop dicts)

Commits

rDSTOa688e822a81f: test_revision_bw_compat: Use revision model object

Summary

Related to T2494

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

refactor-test

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13670
Build 20944: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20943: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 16 2020, 12:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 16 2020, 12:08 PM

Build is green

Patch application report for D3523 (id=12448)

Could not rebase; Attempt merge onto 14b1648889...

Updating 14b16488..a688e822
Fast-forward
 swh/storage/tests/test_buffer.py             | 143 +++++++++++++--------------
 swh/storage/tests/test_filter.py             |  54 +++++-----
 swh/storage/tests/test_retry.py              |  93 +++++++++--------
 swh/storage/tests/test_revision_bw_compat.py |   7 +-
 4 files changed, 157 insertions(+), 140 deletions(-)

Changes applied before test

commit a688e822a81f2b247a0aba4a1abc8fc0f91cd5bc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 10:26:03 2020 +0200

    test_revision_bw_compat: Use revision model object
    
    Related to T2494

commit 21efe2a09ea6c77f51ddd142c1e8fc2d897a0398
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 15 20:05:46 2020 +0200

    test_filter: Use model objects in tests and drop validate proxy

commit 2ff4c6fcd5e760ec5895609aba784995335bb5b1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 15 19:29:45 2020 +0200

    test_buffer: Use model objects in tests and drop validate proxy

commit df45641008cd4a74db1d40f307a70013bed6f7b8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jul 15 19:07:32 2020 +0200

    test_retry: Drop validate proxy when we can
    
    When we use the sample_data_model (almost all object types except the metadata
    ones), we can use a storage with no validate proxy.
    
    Depends on D3510

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/464/ for more details.

Harbormaster completed remote builds in B13670: Diff 12448.Jul 16 2020, 12:25 PM

anlambert accepted this revision.Jul 16 2020, 1:41 PM

This revision is now accepted and ready to land.Jul 16 2020, 1:41 PM

Closed by commit rDSTOa688e822a81f: test_revision_bw_compat: Use revision model object (authored by ardumont). · Explain WhyJul 16 2020, 1:59 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOa688e822a81f: test_revision_bw_compat: Use revision model object.