Differential D3438

tests: Reuse loader-core test utility function
ClosedPublic
Actions

Authored by ardumont on Jul 6 2020, 6:10 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2482: Migrate git loader tests code to pytest

Commits

rDLDGfc2ec733aa5c: tests: Reuse loader-core test utility function

Summary

As mentioned in D3428

Related to T2482

Depends on D3431 D3432 D3433

Test Plan

tox
(failing until release swh.loader.core 0.5.2)

Diff Detail

Repository

rDLDG Git loader

Branch

migrate-pytest

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13392
Build 20478: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20477: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_from_disk ImportError while importing test module '/var/lib/jenkins/workspace/DLDG/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/git/tests/test_from_disk.py'. Hint: make sure your test modules/packages have valid Python names. Traceback:
	0 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.loader.git.tests.test_loader ImportError while importing test module '/var/lib/jenkins/workspace/DLDG/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/loader/git/tests/test_loader.py'. Hint: make sure your test modules/packages have valid Python names. Traceback:

Event Timeline

ardumont created this revision.Jul 6 2020, 6:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2020, 6:10 PM

ardumont edited the summary of this revision. (Show Details)Jul 6 2020, 6:11 PM

ardumont added parent revisions: D3433: Move remaining common test utility functions to top-level arborescence, D3432: Move common test utility function to the top-level arborescence.

Build has FAILED

Patch application report for D3438 (id=12172)

Rebasing onto f0e48ff781...

Current branch diff-target is up to date.

Changes applied before test

commit d767b5b2c34fb6ce901ac28137c9421b13327f40
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 18:07:58 2020 +0200

    tests: Reuse loader-core test utility function
    
    Related to T2482

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/30/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/30/console

Harbormaster failed remote builds in B13392: Diff 12172!Jul 6 2020, 6:11 PM

ardumont edited the test plan for this revision. (Show Details)Jul 6 2020, 6:12 PM

Use proper version requirement on loader-core

Build has FAILED

Patch application report for D3438 (id=12173)

Rebasing onto f0e48ff781...

Current branch diff-target is up to date.

Changes applied before test

commit fc2ec733aa5cc9e0d1682c1359a447b9aa2e2ac9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 18:07:58 2020 +0200

    tests: Reuse loader-core test utility function
    
    Related to T2482

Link to build: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/31/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/31/console

Harbormaster failed remote builds in B13393: Diff 12173!Jul 6 2020, 6:13 PM

vlorentz accepted this revision.Jul 7 2020, 9:41 AM

This revision is now accepted and ready to land.Jul 7 2020, 9:41 AM

Build is green

Patch application report for D3438 (id=12173)

Rebasing onto f0e48ff781...

Current branch diff-target is up to date.

Changes applied before test

commit fc2ec733aa5cc9e0d1682c1359a447b9aa2e2ac9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 6 18:07:58 2020 +0200

    tests: Reuse loader-core test utility function
    
    Related to T2482

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/32/ for more details.

Harbormaster completed remote builds in B13393: Diff 12173.Jul 7 2020, 12:42 PM

Closed by commit rDLDGfc2ec733aa5c: tests: Reuse loader-core test utility function (authored by ardumont). · Explain WhyJul 7 2020, 12:43 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDGfc2ec733aa5c: tests: Reuse loader-core test utility function.