Differential D3420

pg-storage: Add missing cur parameter passing
ClosedPublic
Actions

Authored by ardumont on Jul 3 2020, 5:57 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTO95fd6608da70: pg-storage: Add missing cur parameter passing

Summary

Although, this also pulled a refactoring on the insertion query as the default
naive approach ended up with issues on cur already being closed [1]

[1] Related to P715 (which i don't understand ¯\_(ツ)_/¯)

Related to D3416

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13339
Build 20384: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20383: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 3 2020, 5:57 PM

ardumont mentioned this in D3416: storage.db: Drop db.origin_visit_upsert behavior.Jul 3 2020, 5:58 PM

Build is green

Patch application report for D3420 (id=12118)

Rebasing onto 348bc7b220...

Current branch diff-target is up to date.

Changes applied before test

commit 95fd6608da7067029c4df4b75d4d403a67d846af
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 3 17:54:04 2020 +0200

    pg-storage: Add missing cur parameter passing
    
    Although, this also pulled a refactoring on the insertion query as the default
    naive approach ended up with issues on cur already being closed [1]
    
    [1] Related to P715
    
    Related to D3416

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/408/ for more details.

Harbormaster completed remote builds in B13339: Diff 12118.Jul 3 2020, 6:03 PM

Thanks!

This revision is now accepted and ready to land.Jul 3 2020, 6:12 PM

Closed by commit rDSTO95fd6608da70: pg-storage: Add missing cur parameter passing (authored by ardumont). · Explain WhyJul 3 2020, 6:41 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO95fd6608da70: pg-storage: Add missing cur parameter passing.