Diffusion Storage manager 348bc7b2204f

storage.db: Drop db.origin_visit_upsert behavior
348bc7b2204f
Actions

Tags

None

Subscribers

None

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

storage.db: Drop db.origin_visit_upsert behavior

The initial desired behavior was to allow creation of origin-visit if they
already had their id set. This is the what's needed for the replayer to actually
work.

But somehow, this left the possibility to update the origin-visit...
This commit fixes it by dropping conflictual origin-visits if any.
In effect, we can no longer overwrite origin-visits (pg-storage wise).

Related to T2310

Details

Provenance

ardumont	Authored on Jul 3 2020, 4:31 PM
ardumont	Pushed on Jul 3 2020, 4:49 PM

Differential Revision

D3416: storage.db: Drop db.origin_visit_upsert behavior

Tasks

T2310: Make origin visits immutable

Build Status

Buildable 13334
Build 20374: test-and-build	Jenkins console · Jenkins

Event Timeline

ardumont added an edge: D3416: storage.db: Drop db.origin_visit_upsert behavior.Jul 3 2020, 4:49 PM

ardumont committed rDSTO348bc7b2204f: storage.db: Drop db.origin_visit_upsert behavior (authored by ardumont).Jul 3 2020, 4:42 PM

ardumont added a task: T2310: Make origin visits immutable.Jul 3 2020, 4:49 PM

Harbormaster completed building B13334: rDSTO348bc7b2204f: storage.db: Drop db.origin_visit_upsert behavior.Jul 3 2020, 4:54 PM

swh-public-ci mentioned this in D3420: pg-storage: Add missing cur parameter passing.Jul 3 2020, 6:03 PM

Commit No Longer Exists

This commit no longer exists in the repository.