Rename all references of swh PIDs to SWHIDs for consistency
ClosedPublic
Actions

Authored by anlambert on Jul 3 2020, 5:44 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS423ac84653c0: Rename all references of swh PIDs to SWHIDs for consistency

Summary

When Software Heritage persistent identifiers were introduced, they were not
yet abbreviated as SWHIDs.

Now that abbreviation is growing adoption, rename old persistent identifiers
refererences in function names, variables names, comments and documentation
for consistency.

It's been a while since I wanted to do that renaming. I did it in one pass
so the diff is huge but basically this is just renaming some stuffs.

Diff Detail

Repository

rDWAPPS Web applications

Branch

pid-to-swhid

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13338
Build 20382: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20381: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 3 2020, 5:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2020, 5:44 PM

Update requirements-swh.txt

Build is green

Patch application report for D3419 (id=12116)

Rebasing onto 299ed02cbe...

Current branch diff-target is up to date.

Changes applied before test

commit 9634d89a6645658e78318c4fba16b9dcbc091453
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jul 3 17:33:11 2020 +0200

    Rename all references of swh PIDs to SWHIDs for consistency
    
    When Software Heritage persistent identifiers were introduced, they were not
    yet abbreviated as SWHIDs.
    
    Now that abbreviation is growing adoption, rename old persistent identifiers
    refererences in function names, variables names, comments and documentation
    for consistency.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/265/ for more details.

Harbormaster completed remote builds in B13337: Diff 12116.Jul 3 2020, 5:53 PM

Build is green

Patch application report for D3419 (id=12117)

Rebasing onto 299ed02cbe...

Current branch diff-target is up to date.

Changes applied before test

commit 423ac84653c06201fa271de9d11e973a0157cc7d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jul 3 17:33:11 2020 +0200

    Rename all references of swh PIDs to SWHIDs for consistency
    
    When Software Heritage persistent identifiers were introduced, they were not
    yet abbreviated as SWHIDs.
    
    Now that abbreviation is growing adoption, rename old persistent identifiers
    refererences in function names, variables names, comments and documentation
    for consistency.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/266/ for more details.

Harbormaster completed remote builds in B13338: Diff 12117.Jul 3 2020, 6:03 PM

vlorentz accepted this revision.Jul 3 2020, 6:09 PM

This revision is now accepted and ready to land.Jul 3 2020, 6:09 PM

Closed by commit rDWAPPS423ac84653c0: Rename all references of swh PIDs to SWHIDs for consistency (authored by anlambert). · Explain WhyJul 3 2020, 6:21 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS423ac84653c0: Rename all references of swh PIDs to SWHIDs for consistency.

ardumont mentioned this in D3455: Migrate to new swhid naming.Jul 8 2020, 10:11 AM

ardumont mentioned this in rDDEP724100409e02: Migrate to new swhid naming.Jul 8 2020, 11:36 AM