Differential D3395

common/service: Ensure to get last status when looking up origin visit
ClosedPublic
Actions

Authored by anlambert on Jul 2 2020, 3:01 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPSa4da1d819a45: common/service: Ensure to get last status when looking up origin visit

Summary

Now that visit statuses are decoupled from visits, ensure to get last status
when looking up an origin visit otherwise erroneous visit info will be
reported by the web application.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 2 2020, 3:01 PM

Build is green

Patch application report for D3395 (id=12038)

Rebasing onto 76d9162807...

Current branch diff-target is up to date.

Changes applied before test

commit a4da1d819a459da3e0215660212778818c83de9e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Jul 2 14:51:43 2020 +0200

    common/service: Ensure to get last status when looking up origin visit
    
    Now that visit statuses are decoupled from visits, ensure to get last status
    when looking up an origin visit otherwise erroneous visit info will be
    reported by the web application.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/264/ for more details.

Harbormaster completed remote builds in B13258: Diff 12038.Jul 2 2020, 3:12 PM

ardumont accepted this revision.Jul 2 2020, 3:25 PM

This revision is now accepted and ready to land.Jul 2 2020, 3:25 PM

Closed by commit rDWAPPSa4da1d819a45: common/service: Ensure to get last status when looking up origin visit (authored by anlambert). · Explain WhyJul 2 2020, 3:52 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSa4da1d819a45: common/service: Ensure to get last status when looking up origin visit.