Differential D3367

Migrate to use the object's object_type field when computing objects
ClosedPublic
Actions

Authored by ardumont on Jun 29 2020, 11:35 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDSVNb268749fdaf5: Migrate to Use the object's object_type field when computing objects

Summary

Note:
Without this, the next swh.model release will break that loader.

Related to D3152

Test Plan

tox

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13166
Build 20097: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20096: arc lint + arc unit

Event Timeline

ardumont created this revision.Jun 29 2020, 11:35 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 29 2020, 11:35 AM

Build has FAILED

Patch application report for D3367 (id=11947)

Rebasing onto 782690bd27...

Current branch diff-target is up to date.

Changes applied before test

commit e7a76d6bc357dcfbd1ad54e46ede6102f98d4b40
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:31:48 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/27/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/27/console

Harbormaster failed remote builds in B13162: Diff 11947!Jun 29 2020, 11:36 AM

ardumont retitled this revision from Migrate to Use the object's object_type field when computing objects to Migrate to use the object's object_type field when computing objects.Jun 29 2020, 11:37 AM

ardumont edited the summary of this revision. (Show Details)

ardumont edited the test plan for this revision. (Show Details)Jun 29 2020, 11:40 AM

Use intermediary variable

Build has FAILED

Patch application report for D3367 (id=11951)

Rebasing onto 782690bd27...

Current branch diff-target is up to date.

Changes applied before test

commit b268749fdaf5eccf8ebb92c50b111caec50a6522
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:31:48 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/28/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/28/console

Harbormaster failed remote builds in B13166: Diff 11951!Jun 29 2020, 11:45 AM

ardumont mentioned this in D3368: Migrate to Use the object's object_type field when computing objects.Jun 29 2020, 11:47 AM

vlorentz accepted this revision.Jun 29 2020, 2:10 PM

This revision is now accepted and ready to land.Jun 29 2020, 2:10 PM

ardumont edited the test plan for this revision. (Show Details)Jun 30 2020, 11:48 AM

Build is green

Patch application report for D3367 (id=11951)

Rebasing onto 782690bd27...

Current branch diff-target is up to date.

Changes applied before test

commit b268749fdaf5eccf8ebb92c50b111caec50a6522
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:31:48 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/29/ for more details.

Harbormaster completed remote builds in B13166: Diff 11951.Jun 30 2020, 11:49 AM

Closed by commit rDLDSVNb268749fdaf5: Migrate to Use the object's object_type field when computing objects (authored by ardumont). · Explain WhyJun 30 2020, 11:54 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVNb268749fdaf5: Migrate to Use the object's object_type field when computing objects.

ardumont mentioned this in D3390: Unify object_type some more within the merkle and from_disk modules.Jul 2 2020, 11:17 AM

ardumont mentioned this in D3391: Refactor common loader behavior within swh.model.from_disk.iter_directory function.Jul 2 2020, 11:58 AM