Page MenuHomeSoftware Heritage

Migrate to use the object's object_type field when computing objects
ClosedPublic

Authored by ardumont on Mon, Jun 29, 11:35 AM.

Details

Summary

Note:
Without this, the next swh.model release will break that loader.

Related to D3152

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mon, Jun 29, 11:35 AM

Build has FAILED

Patch application report for D3367 (id=11947)

Rebasing onto 782690bd27...

Current branch diff-target is up to date.
Changes applied before test
commit e7a76d6bc357dcfbd1ad54e46ede6102f98d4b40
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:31:48 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/27/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/27/console

ardumont retitled this revision from Migrate to Use the object's object_type field when computing objects to Migrate to use the object's object_type field when computing objects.Mon, Jun 29, 11:37 AM
ardumont edited the summary of this revision. (Show Details)
ardumont edited the test plan for this revision. (Show Details)Mon, Jun 29, 11:40 AM
ardumont updated this revision to Diff 11951.Mon, Jun 29, 11:44 AM

Use intermediary variable

Build has FAILED

Patch application report for D3367 (id=11951)

Rebasing onto 782690bd27...

Current branch diff-target is up to date.
Changes applied before test
commit b268749fdaf5eccf8ebb92c50b111caec50a6522
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:31:48 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/28/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/28/console

vlorentz accepted this revision.Mon, Jun 29, 2:10 PM
This revision is now accepted and ready to land.Mon, Jun 29, 2:10 PM
ardumont edited the test plan for this revision. (Show Details)Tue, Jun 30, 11:48 AM

Build is green

Patch application report for D3367 (id=11951)

Rebasing onto 782690bd27...

Current branch diff-target is up to date.
Changes applied before test
commit b268749fdaf5eccf8ebb92c50b111caec50a6522
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jun 29 11:31:48 2020 +0200

    Migrate to Use the object's object_type field when computing objects
    
    Related to D3152

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/29/ for more details.