Page MenuHomeSoftware Heritage
Differential D3353

Use proper hash ids in tests' journal_data
ClosedPublic
Actions

Authored by douardda on Jun 25 2020, 1:03 PM.

Details

Reviewers
vlorentz
ardumont
Group Reviewers
Reviewers
Commits
rDJNLaff31e54e966: Use proper hash ids in tests' journal_data
Summary

for the sake of correctness.

Diff Detail

Event Timeline

douardda created this revision.Jun 25 2020, 1:03 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 25 2020, 1:03 PM
swh-public-ci added a comment.Jun 25 2020, 1:05 PM

Build is green

Patch application report for D3353 (id=11890)

Rebasing onto 84641aeddc...

Current branch diff-target is up to date.
Changes applied before test
commit aff31e54e96622efd1ba9e4e253c873754980758
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Jun 25 10:41:09 2020 +0200

    Use proper hash ids in tests' journal_data
    
    for the sake of correctness.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/99/ for more details.

Harbormaster completed remote builds in B13104: Diff 11890.Jun 25 2020, 1:05 PM
vlorentz accepted this revision.Jun 25 2020, 1:18 PM
This revision is now accepted and ready to land.Jun 25 2020, 1:18 PM
vlorentz added a comment.Jun 25 2020, 1:19 PM

do you know where the old hashes came from?

ardumont accepted this revision.Jun 25 2020, 7:09 PM
douardda added a comment.Jun 26 2020, 9:22 AM
In D3353#82224, @vlorentz wrote:

do you know where the old hashes came from?

no idea nope.

Closed by commit rDJNLaff31e54e966: Use proper hash ids in tests' journal_data (authored by douardda). · Explain WhyJun 26 2020, 9:23 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDJNLaff31e54e966: Use proper hash ids in tests' journal_data.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
journal/
tests/
18 lines0%
Loading...

Diff 11890

View Options

swh/journal/tests/journal_data.py

Loading...
About · Developer information · Legal