Differential D3300

validate: accept model objects as well as dicts on all add endpoints
ClosedPublic
Actions

Authored by olasd on Jun 17 2020, 11:23 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO057c6fd5dfce: validate: accept model objects as well as dicts on all add endpoints

Summary

This generalizes work by @ardumont to all object addition endpoints, as a
further step towards completely dropping the validate proxy in tests.

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

arcpatch-D3298

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12902
Build 19645: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19644: arc lint + arc unit

Event Timeline

olasd created this revision.Jun 17 2020, 11:23 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 17 2020, 11:23 AM

olasd mentioned this in D3298: validate.snapshot_add: Make it able to deal directly with Snapshot.Jun 17 2020, 11:27 AM

ardumont accepted this revision.Jun 17 2020, 11:31 AM

This revision is now accepted and ready to land.Jun 17 2020, 11:31 AM

Build is green

Patch application report for D3300 (id=11693)

Rebasing onto d153a8096d...

Current branch diff-target is up to date.

Changes applied before test

commit 057c6fd5dfcedf07529a18faf09c5a7ed0a81379
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Wed Jun 17 11:22:13 2020 +0200

    validate: accept model objects as well as dicts on all add endpoints
    
    This generalizes work by Antoine Dumont to all object addition endpoints, as a
    further step towards completely dropping the validate proxy in tests.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/294/ for more details.

Harbormaster completed remote builds in B12902: Diff 11693.Jun 17 2020, 11:31 AM

Closed by commit rDSTO057c6fd5dfce: validate: accept model objects as well as dicts on all add endpoints (authored by olasd). · Explain WhyJun 17 2020, 11:33 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO057c6fd5dfce: validate: accept model objects as well as dicts on all add endpoints.