Differential D3290

Fix db_to_author() converter to return None is all fields are None
ClosedPublic
Actions

Authored by douardda on Jun 16 2020, 12:22 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2455: backfiller: properly support null authors

Commits

rDSTOc2b673b49b88: Fix db_to_author() converter to return None is all fields are None

Summary

Fix T2455.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12872
Build 19597: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19596: arc lint + arc unit

Event Timeline

douardda created this revision.Jun 16 2020, 12:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 16 2020, 12:22 PM

Looks like a plausible change.

Please fix the docstring, which is obviously lying :-)

Build is green

Patch application report for D3290 (id=11664)

Rebasing onto 8f1ac4cb13...

Current branch diff-target is up to date.

Changes applied before test

commit 990ac281fd4108fd0ef8a90e76e774820c854d15
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 12:19:13 2020 +0200

    Fix db_to_author() converter to return None is all fields are None
    
    Fix T2455.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/283/ for more details.

Harbormaster completed remote builds in B12872: Diff 11664.Jun 16 2020, 12:30 PM

update the docstring and add type annotations

olasd accepted this revision.Jun 16 2020, 12:35 PM

This revision is now accepted and ready to land.Jun 16 2020, 12:35 PM

Build is green

Patch application report for D3290 (id=11665)

Rebasing onto 8f1ac4cb13...

Current branch diff-target is up to date.

Changes applied before test

commit c2b673b49b88395a5b4d21d2e0b39462e50cc459
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Jun 16 12:19:13 2020 +0200

    Fix db_to_author() converter to return None is all fields are None
    
    Fix T2455.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/284/ for more details.

Harbormaster completed remote builds in B12873: Diff 11665.Jun 16 2020, 12:42 PM

Closed by commit rDSTOc2b673b49b88: Fix db_to_author() converter to return None is all fields are None (authored by douardda). · Explain WhyJun 16 2020, 1:59 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTOc2b673b49b88: Fix db_to_author() converter to return None is all fields are None.