Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T2324: Modify layout of save code now page
- Commits
- rDWAPPS02a2d3f7639f: templates/origin-save: Update "Save code now" page layout
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- save-code-now-layout-update
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12708 Build 19323: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 19322: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3245 (id=11504)
Could not rebase; Attempt merge onto 3e17ef162e...
Updating 3e17ef16..0c1bb13d Fast-forward cypress/fixtures/origin-save.json | 86 +++++++++++++++++++++++++ cypress/integration/origin-save.spec.js | 32 +++++++++ swh/web/assets/src/bundles/admin/origin-save.js | 21 +++--- swh/web/assets/src/bundles/save/index.js | 47 ++++++++------ swh/web/templates/misc/origin-save.html | 74 +++++++++++---------- 5 files changed, 196 insertions(+), 64 deletions(-) create mode 100644 cypress/fixtures/origin-save.json
Changes applied before test
commit 0c1bb13d373a09a756a764c66486dcaccfc55928
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Mon Jun 8 18:01:56 2020 +0200
templates/origin-save: Update "Save code now" page layout
Make the save request form always visible by moving it from the "Create
save request" tab to the top of the page.
Rename "Create save request" tab to "Help".
Rename "Submit" button to "Save".
Make all html alerts closable.
Closes T2324
commit 086efa0b58f1f92860fc8c0b27c3fa370069c3a4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Mon Jun 8 16:10:53 2020 +0200
assets/save: Improve links in save requests table
Make the main link in each row targets the origin copy in the archive
if it has been successfully loaded.
Add a link to each origin through an external link icon.
Closes T2405See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/160/ for more details.
| swh/web/templates/misc/origin-save.html | ||
|---|---|---|
| 49 | Why did you rename it from Submit to Save? Submit makes it clearer it's a request, imo | |
Comment Actions
Build is green
Patch application report for D3245 (id=11513)
Could not rebase; Attempt merge onto 3e17ef162e...
Updating 3e17ef16..02a2d3f7 Fast-forward cypress/fixtures/origin-save.json | 86 +++++++++++++++++++++++++ cypress/integration/origin-save.spec.js | 32 +++++++++ swh/web/assets/src/bundles/admin/origin-save.js | 21 +++--- swh/web/assets/src/bundles/save/index.js | 47 ++++++++------ swh/web/templates/misc/origin-save.html | 74 +++++++++++---------- 5 files changed, 196 insertions(+), 64 deletions(-) create mode 100644 cypress/fixtures/origin-save.json
Changes applied before test
commit 02a2d3f7639f884c799571044910f119fd8e9146
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Mon Jun 8 18:01:56 2020 +0200
templates/origin-save: Update "Save code now" page layout
Make the save request form always visible by moving it from the "Create
save request" tab to the top of the page.
Rename "Create save request" tab to "Help".
Make all html alerts closable.
Closes T2324
commit 086efa0b58f1f92860fc8c0b27c3fa370069c3a4
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date: Mon Jun 8 16:10:53 2020 +0200
assets/save: Improve links in save requests table
Make the main link in each row targets the origin copy in the archive
if it has been successfully loaded.
Add a link to each origin through an external link icon.
Closes T2405See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/161/ for more details.