Differential D3233

assets/visits-calendar: Ensure popover disposal when mouse leaves
ClosedPublic
Actions

Authored by anlambert on Jun 5 2020, 2:48 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2426: Remove date popups on the visit page when cursor doesn't point it anymore

Commits

rDWAPPS7888549d8ca4: assets/visits-calendar: Ensure popover disposal when mouse leaves

Summary

Ensure day popovers will be disposed when the mouse pointer leaves the
day on calendar or leaves the popover.

Closes T2426

Test Plan

I added a cypress test for the day leave case.
Unfortunately, I could not manage to write a functional test with cypress
for the popover leave case. Hovering events are hard to simulate.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 5 2020, 2:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2020, 2:48 PM

What we can do these days ;)

This revision is now accepted and ready to land.Jun 5 2020, 2:50 PM

Build is green

Patch application report for D3233 (id=11462)

Rebasing onto d30ccc6887...

Current branch diff-target is up to date.

Changes applied before test

commit 7888549d8ca4648ec7ff8abe5d093c1ad4226e28
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 5 11:41:36 2020 +0200

    assets/visits-calendar: Ensure popover disposal when mouse leaves
    
    Ensure day popovers will be disposed when the mouse pointer leaves the
    day on calendar or leaves the popover.
    
    Closes T2426

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/152/ for more details.

Harbormaster completed remote builds in B12667: Diff 11462.Jun 5 2020, 3:01 PM

Closed by commit rDWAPPS7888549d8ca4: assets/visits-calendar: Ensure popover disposal when mouse leaves (authored by anlambert). · Explain WhyJun 5 2020, 3:15 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS7888549d8ca4: assets/visits-calendar: Ensure popover disposal when mouse leaves.