Differential D3231

Small refactoring of the InMemoryStorage to make it more consistent
ClosedPublic
Actions

Authored by douardda on Jun 5 2020, 12:33 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTOc75da7a90e1d: Small refactoring of the InMemoryStorage to make it more consistent

Summary

make self._persons a dict
make self._snapshots value Snapshot only instead of the couple (Snapshot, sorted_branch_names)

Diff Detail

Repository

rDSTO Storage manager

Branch

anonymized_topics_2

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 12660
Build 19242: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19241: arc lint + arc unit

Event Timeline

douardda created this revision.Jun 5 2020, 12:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2020, 12:33 PM

douardda added a child revision: D3232: Add a replayer test for anonymized journal topics.Jun 5 2020, 12:33 PM

Build is green

Patch application report for D3231 (id=11456)

Rebasing onto 25f584ffc4...

Current branch diff-target is up to date.

Changes applied before test

commit c75da7a90e1d9c1418600b1b9519afc2ab447d6e
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jun 5 12:25:58 2020 +0200

    Small refactoring of the InMemoryStorage to make it more consistent
    
    - make self._persons a dict
    - make self._snapshots value Snapshot only instead of the couple
      (Snapshot, sorted_branch_names)

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/228/ for more details.

Harbormaster completed remote builds in B12660: Diff 11456.Jun 5 2020, 12:41 PM