Page MenuHomeSoftware Heritage

deposit-admin: Improve existing tests
ClosedPublic

Authored by ardumont on May 23 2020, 9:24 AM.

Details

Summary

This improves the recent new existing test assertions.

Related to T2406

Test Plan

tox

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12466
Build 18921: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18920: arc lint + arc unit

Event Timeline

Decomment commented checks and tests

Build is green

Patch application report for D3175 (id=11276)

Rebasing onto 7d3c769a3f...

Current branch diff-target is up to date.
Changes applied before test
commit 28b828b06ecc68b9ea166ff722542b72b45617e9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat May 23 09:17:37 2020 +0200

    deposit-admin: Filtering out deposits matching an excluding pattern
    
    The matching is only done on the external_id column. A commented implementation
    looking up all columns could be used instead.
    
    Related to T2406

commit 87e7fbc9c2e7e946cc33d3301f2148ebdca39d11
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 22 13:32:22 2020 +0200

    deposit-admin-spec: Improve default tests on admin page

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/136/ for more details.

Build is green

Patch application report for D3175 (id=11277)

Rebasing onto 7d3c769a3f...

Current branch diff-target is up to date.
Changes applied before test
commit 671be5c7053b656bfb5b70f6d7dce05c894cb9aa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat May 23 09:17:37 2020 +0200

    deposit-admin: Filtering out deposits matching an excluding pattern
    
    The matching is only done on the external_id column. A commented implementation
    looking up all columns could be used instead.
    
    Related to T2406

commit 87e7fbc9c2e7e946cc33d3301f2148ebdca39d11
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 22 13:32:22 2020 +0200

    deposit-admin-spec: Improve default tests on admin page

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/137/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.May 25 2020, 9:14 AM
This revision was automatically updated to reflect the committed changes.
ardumont retitled this revision from deposit-admin: Filtering out deposits matching an excluding pattern to deposit-admin: Improve existing tests.May 25 2020, 9:16 AM
ardumont edited the summary of this revision. (Show Details)