Page MenuHomeSoftware Heritage
Differential D3175

deposit-admin: Improve existing tests
ClosedPublic
Actions

Authored by ardumont on May 23 2020, 9:24 AM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T2406: Allow filtering out test deposits on the deposit admin page
Commits
rDWAPPS87e7fbc9c2e7: deposit-admin-spec: Improve default tests on admin page
Summary

This improves the recent new existing test assertions.

Related to T2406

Test Plan

tox

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 23 2020, 9:24 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 23 2020, 9:24 AM
ardumont updated this revision to Diff 11277.May 23 2020, 9:27 AM

Decomment commented checks and tests

swh-public-ci added a comment.May 23 2020, 9:32 AM

Build is green

Patch application report for D3175 (id=11276)

Rebasing onto 7d3c769a3f...

Current branch diff-target is up to date.
Changes applied before test
commit 28b828b06ecc68b9ea166ff722542b72b45617e9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat May 23 09:17:37 2020 +0200

    deposit-admin: Filtering out deposits matching an excluding pattern
    
    The matching is only done on the external_id column. A commented implementation
    looking up all columns could be used instead.
    
    Related to T2406

commit 87e7fbc9c2e7e946cc33d3301f2148ebdca39d11
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 22 13:32:22 2020 +0200

    deposit-admin-spec: Improve default tests on admin page

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/136/ for more details.

Harbormaster completed remote builds in B12466: Diff 11276.May 23 2020, 9:32 AM
swh-public-ci added a comment.May 23 2020, 9:41 AM

Build is green

Patch application report for D3175 (id=11277)

Rebasing onto 7d3c769a3f...

Current branch diff-target is up to date.
Changes applied before test
commit 671be5c7053b656bfb5b70f6d7dce05c894cb9aa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sat May 23 09:17:37 2020 +0200

    deposit-admin: Filtering out deposits matching an excluding pattern
    
    The matching is only done on the external_id column. A commented implementation
    looking up all columns could be used instead.
    
    Related to T2406

commit 87e7fbc9c2e7e946cc33d3301f2148ebdca39d11
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 22 13:32:22 2020 +0200

    deposit-admin-spec: Improve default tests on admin page

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/137/ for more details.

Harbormaster completed remote builds in B12467: Diff 11277.May 23 2020, 9:41 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2020, 9:14 AM
Closed by commit rDWAPPS87e7fbc9c2e7: deposit-admin-spec: Improve default tests on admin page (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDWAPPS87e7fbc9c2e7: deposit-admin-spec: Improve default tests on admin page.
ardumont mentioned this in D3176: deposit-admin: Filtering out deposits matching an excluding pattern.May 25 2020, 9:16 AM
ardumont retitled this revision from deposit-admin: Filtering out deposits matching an excluding pattern to deposit-admin: Improve existing tests.May 25 2020, 9:16 AM
ardumont edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

PathSize
cypress/
integration/
60 lines

Diff 11278

View Options

cypress/integration/deposit-admin.spec.js

Loading...
About · Developer information · Legal