Differential D3135

templates/show-swh-ids: Add display of new SWHID contextual information
ClosedPublic
Actions

Authored by anlambert on May 7 2020, 4:12 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2330: Simplify Permalinks box

Commits

rDWAPPS23f07024a291: templates/show-swh-ids: Add display of new SWHID contextual information

Summary

Updated contextual info for SWHIDs are now displayed in the "Permalinks" tab.

There is now a single checkbox to add / remove these contextual info.

Add tests checking the expected SWHIDs are present in generated HTML pages.

Closes T2330

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 7 2020, 4:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 7 2020, 4:12 PM

Build is green

Patch application report for D3135 (id=11142)

Rebasing onto 6d00ef0a28...

Current branch diff-target is up to date.

Changes applied before test

commit c680ea3094e7d3a81a4982030d99df76234f594c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 4 17:42:01 2020 +0200

    templates/show-swh-ids: Add display of new SWHID contextual information
    
    Updated contextual info for SWHIDs are now displayed in the "Permalinks" tab.
    
    There is now a single checkbox to add / remove these contextual info.
    
    Add tests checking the expected SWHIDs are present in generated HTML pages.
    
    Closes T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/122/ for more details.

Harbormaster completed remote builds in B12315: Diff 11142.May 7 2020, 4:21 PM

Update: Fix release anchors and add test

Build is green

Patch application report for D3135 (id=11147)

Rebasing onto 6d00ef0a28...

Current branch diff-target is up to date.

Changes applied before test

commit 23f07024a2914a7ba45f779ac18707798fd5b624
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 4 17:42:01 2020 +0200

    templates/show-swh-ids: Add display of new SWHID contextual information
    
    Updated contextual info for SWHIDs are now displayed in the "Permalinks" tab.
    
    There is now a single checkbox to add / remove these contextual info.
    
    Add tests checking the expected SWHIDs are present in generated HTML pages.
    
    Closes T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/123/ for more details.

Harbormaster completed remote builds in B12320: Diff 11147.May 7 2020, 5:32 PM

ardumont accepted this revision.May 7 2020, 5:58 PM

This revision is now accepted and ready to land.May 7 2020, 5:58 PM

Closed by commit rDWAPPS23f07024a291: templates/show-swh-ids: Add display of new SWHID contextual information (authored by anlambert). · Explain WhyMay 7 2020, 6:08 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS23f07024a291: templates/show-swh-ids: Add display of new SWHID contextual information.