Page MenuHomeSoftware Heritage
Differential D3092

browse/directory: Refactor metadata handling and add typing
ClosedPublic
Actions

Authored by anlambert on Apr 29 2020, 4:22 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2330: Simplify Permalinks box
Commits
rDWAPPS897d81f1b0df: browse/directory: Refactor metadata handling and add typing
Summary

Continue refactoring and typing archived objects metadata by processing directory views.

Related to T2330

Depends on D3089.

Diff Detail

Repository
rDWAPPS Web applications
Branch
directory-metadata-cleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12192
Build 18489: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18488: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 29 2020, 4:22 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 29 2020, 4:22 PM
swh-public-ci added a comment.Apr 29 2020, 4:31 PM

Build is green

Patch application report for D3092 (id=10995)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..7cd4abd6
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  13 ++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 210 insertions(+), 117 deletions(-)
Changes applied before test
commit 7cd4abd65232d7b68674812fd2b946671301ed8c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 529ab7cb2b5f96c2df0f5883e5e0d133b4fdce14
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 8a512d60c96b85f11cb5aa7f512a71a6c64b972b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/95/ for more details.

Harbormaster completed remote builds in B12149: Diff 10995.Apr 29 2020, 4:31 PM
vlorentz accepted this revision.Apr 29 2020, 4:35 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/browse/views/directory.py
136

path=path or None

This revision is now accepted and ready to land.Apr 29 2020, 4:35 PM
anlambert updated this revision to Diff 11004.Apr 29 2020, 5:24 PM

Rebase

anlambert added a child revision: D3094: browse/release: Refactor metadata handling and add typing.Apr 29 2020, 5:29 PM
swh-public-ci added a comment.Apr 29 2020, 5:42 PM

Build is green

Patch application report for D3092 (id=11004)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..bd8997e1
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  17 ++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 214 insertions(+), 117 deletions(-)
Changes applied before test
commit bd8997e1061cb709a61436946bed6c2347d98cfa
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit c4f95517ebf3111f27d10e8522f23757a025f84e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit be38eb1abfe640562cb158cec5f8b81ec2ca2729
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/98/ for more details.

Harbormaster completed remote builds in B12158: Diff 11004.Apr 29 2020, 5:42 PM
anlambert updated this revision to Diff 11010.Apr 29 2020, 7:32 PM

Rebase

swh-public-ci added a comment.Apr 29 2020, 7:53 PM

Build is green

Patch application report for D3092 (id=11010)

Could not rebase; Attempt merge onto c8bca2af35...

Merge made by the 'recursive' strategy.
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 +++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 218 insertions(+), 117 deletions(-)
Changes applied before test
commit abc549cff7997bda5baa739e383a4e4a511bd5e7
Merge: c8bca2af 60016e97
Author: Jenkins user <jenkins@localhost>
Date:   Wed Apr 29 17:46:07 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 60016e97ed53b224a75a7c38a8a69a9d2af688c3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 8f118ab40bbf5ce8f209d3b3b798097122b78c57
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit cf53eb0d21f2674e480d99af4a699b695b56daa5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/102/ for more details.

Harbormaster completed remote builds in B12186: Diff 11010.Apr 29 2020, 7:53 PM
anlambert updated this revision to Diff 11017.Apr 30 2020, 11:49 AM

Rebase

swh-public-ci added a comment.Apr 30 2020, 12:13 PM

Build is green

Patch application report for D3092 (id=11017)

Could not rebase; Attempt merge onto c8bca2af35...

Updating c8bca2af..897d81f1
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 +++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 218 insertions(+), 117 deletions(-)
Changes applied before test
commit 897d81f1b0dfbcc04e0bca554017db8cd3518461
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 7bbd64d4e63e3ed454aac0e07544e3845278625e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 51f2af1e78cddedea597bb8770d51da73a4352d7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/107/ for more details.

Harbormaster completed remote builds in B12192: Diff 11017.Apr 30 2020, 12:13 PM
Closed by commit rDWAPPS897d81f1b0df: browse/directory: Refactor metadata handling and add typing (authored by anlambert). · Explain WhyApr 30 2020, 12:46 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS897d81f1b0df: browse/directory: Refactor metadata handling and add typing.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
browse/
64 lines81%
Loading...
views/
20 lines75%
Loading...
common/
12 lines100%
Loading...

Diff 11017

View Options

swh/web/browse/snapshot_context.py

Loading...
View Options

swh/web/browse/views/directory.py

Loading...
View Options

swh/web/common/typing.py

Loading...
About · Developer information · Legal