Page MenuHomeSoftware Heritage

browse/directory: Refactor metadata handling and add typing
ClosedPublic

Authored by anlambert on Apr 29 2020, 4:22 PM.

Details

Summary

Continue refactoring and typing archived objects metadata by processing directory views.

Related to T2330

Depends on D3089.

Diff Detail

Repository
rDWAPPS Web applications
Branch
directory-metadata-cleanup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12186
Build 18478: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18477: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3092 (id=10995)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..7cd4abd6
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  13 ++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 210 insertions(+), 117 deletions(-)
Changes applied before test
commit 7cd4abd65232d7b68674812fd2b946671301ed8c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 529ab7cb2b5f96c2df0f5883e5e0d133b4fdce14
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 8a512d60c96b85f11cb5aa7f512a71a6c64b972b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/95/ for more details.

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/browse/views/directory.py
136

path=path or None

This revision is now accepted and ready to land.Apr 29 2020, 4:35 PM

Build is green

Patch application report for D3092 (id=11004)

Could not rebase; Attempt merge onto 57855a8dc5...

Updating 57855a8d..bd8997e1
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  17 ++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 214 insertions(+), 117 deletions(-)
Changes applied before test
commit bd8997e1061cb709a61436946bed6c2347d98cfa
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit c4f95517ebf3111f27d10e8522f23757a025f84e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit be38eb1abfe640562cb158cec5f8b81ec2ca2729
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/98/ for more details.

Build is green

Patch application report for D3092 (id=11010)

Could not rebase; Attempt merge onto c8bca2af35...

Merge made by the 'recursive' strategy.
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 +++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 218 insertions(+), 117 deletions(-)
Changes applied before test
commit abc549cff7997bda5baa739e383a4e4a511bd5e7
Merge: c8bca2af 60016e97
Author: Jenkins user <jenkins@localhost>
Date:   Wed Apr 29 17:46:07 2020 +0000

    Merge branch 'diff-target' into HEAD

commit 60016e97ed53b224a75a7c38a8a69a9d2af688c3
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 8f118ab40bbf5ce8f209d3b3b798097122b78c57
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit cf53eb0d21f2674e480d99af4a699b695b56daa5
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/102/ for more details.

Build is green

Patch application report for D3092 (id=11017)

Could not rebase; Attempt merge onto c8bca2af35...

Updating c8bca2af..897d81f1
Fast-forward
 cypress/integration/persistent-identifiers.spec.js |  11 ++
 swh/web/assets/src/bundles/webapp/webapp-utils.js  |  21 +++
 swh/web/browse/snapshot_context.py                 | 180 +++++++++++----------
 swh/web/browse/views/content.py                    |  58 ++++---
 swh/web/browse/views/directory.py                  |  20 ++-
 swh/web/common/typing.py                           |  42 +++++
 swh/web/templates/includes/show-swh-ids.html       |   3 +
 7 files changed, 218 insertions(+), 117 deletions(-)
Changes applied before test
commit 897d81f1b0dfbcc04e0bca554017db8cd3518461
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 16:20:48 2020 +0200

    browse/directory: Refactor metadata handling and add typing
    
    Related to T2330

commit 7bbd64d4e63e3ed454aac0e07544e3845278625e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:57:39 2020 +0200

    browse/content: Refactor metadata handling and add typing
    
    Related to T2330

commit 51f2af1e78cddedea597bb8770d51da73a4352d7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Apr 29 14:33:52 2020 +0200

    assets/webapp: Add SWHIDs context related functions
    
    Enable to get SWHIDs context from JavaScript for the currently
    browsed object.
    
    Related to T2330

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/107/ for more details.