Page MenuHomeSoftware Heritage

pytest.ini: Avoid loading flask plugin to prevent fixture name clash
ClosedPublic

Authored by anlambert on Apr 23 2020, 2:57 PM.

Details

Summary

pytest-django and pytest-flask both declare a fixture named client and
the wrong one is picked when running swh-deposit tests.

So avoid the loading of pytest flask plugin to prevent errors when
running tests.

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12006
Build 18208: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18207: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3051 (id=10851)

Rebasing onto b91abac189...

Current branch diff-target is up to date.
Changes applied before test
commit d1a244c7cdc7654835e4f6b6680801ada79e1996
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 14:56:06 2020 +0200

    pytest.ini: Avoid loading flask plugin to prevent fixture name clash
    
    pytest-django and pytest-flask both declare a fixture named client and
    the wrong one is picked when running swh-deposit tests.
    
    So avoid the loading of pytest flask plugin to prevent errors when
    running tests.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/7/ for more details.

This revision is now accepted and ready to land.Apr 23 2020, 3:28 PM