Differential D3051

pytest.ini: Avoid loading flask plugin to prevent fixture name clash
ClosedPublic
Actions

Authored by anlambert on Apr 23 2020, 2:57 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEPd1a244c7cdc7: pytest.ini: Avoid loading flask plugin to prevent fixture name clash

Summary

pytest-django and pytest-flask both declare a fixture named client and
the wrong one is picked when running swh-deposit tests.

So avoid the loading of pytest flask plugin to prevent errors when
running tests.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 23 2020, 2:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 23 2020, 2:57 PM

Build is green

Patch application report for D3051 (id=10851)

Rebasing onto b91abac189...

Current branch diff-target is up to date.

Changes applied before test

commit d1a244c7cdc7654835e4f6b6680801ada79e1996
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 23 14:56:06 2020 +0200

    pytest.ini: Avoid loading flask plugin to prevent fixture name clash
    
    pytest-django and pytest-flask both declare a fixture named client and
    the wrong one is picked when running swh-deposit tests.
    
    So avoid the loading of pytest flask plugin to prevent errors when
    running tests.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/7/ for more details.

Harbormaster completed remote builds in B12006: Diff 10851.Apr 23 2020, 3:00 PM

ardumont accepted this revision.Apr 23 2020, 3:28 PM

This revision is now accepted and ready to land.Apr 23 2020, 3:28 PM

Closed by commit rDDEPd1a244c7cdc7: pytest.ini: Avoid loading flask plugin to prevent fixture name clash (authored by anlambert). · Explain WhyApr 23 2020, 3:53 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDDEPd1a244c7cdc7: pytest.ini: Avoid loading flask plugin to prevent fixture name clash.