tests: Fix errors and deprecation warning
ClosedPublic
Actions

Authored by anlambert on Apr 6 2020, 11:28 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDVAU47345e2da781: tests/test_cookers: Fix new errors after swh-model 0.0.64 release
rDVAU6f0ce5324664: tests/conftest: Fix deprecation warning

Summary

tests/test_cookers: Fix new errors after swh-model 0.0.64 release

tests/conftest: Fix deprecation warning about storage configuration

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

fix-new-failing-tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11628
Build 17634: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17633: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 6 2020, 11:28 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 6 2020, 11:28 AM

Build is green

Patch application report for D2959 (id=10538)

Rebasing onto c5ddbcc73e...

Current branch diff-target is up to date.

Changes applied before test

commit 0d1c4aa764909813fbd6eb46f5bbde478475c1e1
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 6 11:27:16 2020 +0200

    tests/test_cookers: Fix new errors after swh-model 0.0.64 release

commit 6f0ce532466427f9333d2a76985f13107039cd60
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 6 11:26:22 2020 +0200

    tests/conftest: Fix deprecation warning

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/3/ for more details.

Harbormaster completed remote builds in B11627: Diff 10538.Apr 6 2020, 11:30 AM

It'd be nice to call the constructors directly instead of from_dict some time

This revision is now accepted and ready to land.Apr 6 2020, 12:20 PM

In D2959#71620, @vlorentz wrote:

It'd be nice to call the constructors directly instead of from_dict some time

Ack, I will update the diff before landing it.

Update: Use directly model object constructors instead of creating them from dict

Build is green

Patch application report for D2959 (id=10539)

Rebasing onto c5ddbcc73e...

Current branch diff-target is up to date.

Changes applied before test

commit 47345e2da7817406a7ffe239584a96afd28ba5ac
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 6 11:27:16 2020 +0200

    tests/test_cookers: Fix new errors after swh-model 0.0.64 release
    
    Also use direcly model object constructors instead of creating them from dict.

commit 6f0ce532466427f9333d2a76985f13107039cd60
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Apr 6 11:26:22 2020 +0200

    tests/conftest: Fix deprecation warning

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/4/ for more details.

Harbormaster completed remote builds in B11628: Diff 10539.Apr 6 2020, 12:41 PM

Closed by commit rDVAU6f0ce5324664: tests/conftest: Fix deprecation warning (authored by anlambert). · Explain WhyApr 6 2020, 12:42 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDVAU6f0ce5324664: tests/conftest: Fix deprecation warning.

anlambert added a commit: rDVAU47345e2da781: tests/test_cookers: Fix new errors after swh-model 0.0.64 release.