Remove magic CassObject class, use dicts instead.
ClosedPublic
Actions

Authored by vlorentz on Apr 2 2020, 4:40 PM.

Details

Reviewers

douardda
ardumont

Group Reviewers

Reviewers

Commits

rDSTO82b41bac01f6: Remove magic CassObject class, use dicts instead.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 11584
Build 17563: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 17562: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 2 2020, 4:40 PM

Build is green

Patch application report for D2947 (id=10492)

Rebasing onto df3207a6b7...

Current branch diff-target is up to date.

Changes applied before test

commit 82b41bac01f6e85785143ec8990f3dc14d5fca98
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 2 16:40:00 2020 +0200

    Remove magic CassObject class, use dicts instead.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/51/ for more details.

Harbormaster completed remote builds in B11584: Diff 10492.Apr 2 2020, 4:45 PM

ardumont accepted this revision.Apr 2 2020, 5:02 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/storage/cassandra/cql.py
368	why do you `inline` the self._add_one? oh, maybe because `_add_one` deals with model objects and not dict. Note: I noticed the cql's _add_one does the increment after the _execute_with_retries.