Page MenuHomeSoftware Heritage
Differential D2946

common: Move PIDs related functions from utils to dedicated sub-module
ClosedPublic
Actions

Authored by anlambert on Apr 2 2020, 4:20 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDWAPPS8b3e0ce543c0: common: Move PIDs related functions from utils to dedicated sub-module
Summary

Move functions related to SWH PIDs in new swh.web.common.identifiers sub-module.

Related to T2342

Diff Detail

Repository
rDWAPPS Web applications
Branch
add-common-identifiers-module
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11581
Build 17557: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 17556: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 2 2020, 4:20 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 2 2020, 4:20 PM
swh-public-ci added a comment.Apr 2 2020, 4:28 PM

Build is green

Patch application report for D2946 (id=10489)

Rebasing onto 2e858f73f6...

Current branch diff-target is up to date.
Changes applied before test
commit 8b3e0ce543c072db36a4e5e838d479b2cca11bf2
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Apr 2 16:16:01 2020 +0200

    common: Move PIDs related functions from utils to dedicated sub-module
    
    Related to T2342

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/39/ for more details.

Harbormaster completed remote builds in B11581: Diff 10489.Apr 2 2020, 4:28 PM
ardumont accepted this revision.Apr 2 2020, 4:53 PM
ardumont added a subscriber: ardumont.

I'd argue to add the types while the code is moved.
But as you wish ;)

swh/web/common/identifiers.py
19

please add the types ;)

54

targetted?

This revision is now accepted and ready to land.Apr 2 2020, 4:53 PM
Closed by commit rDWAPPS8b3e0ce543c0: common: Move PIDs related functions from utils to dedicated sub-module (authored by anlambert). · Explain WhyApr 2 2020, 4:57 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS8b3e0ce543c0: common: Move PIDs related functions from utils to dedicated sub-module.
anlambert added a comment.Apr 2 2020, 5:01 PM
In D2946#71290, @ardumont wrote:

I'd argue to add the types while the code is moved.
But as you wish ;)

D2948 ;-)

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
api/
views/
14 lines100%
Loading...
browse/
4 lines100%
Loading...
4 lines87%
Loading...
common/
168 lines100%
Loading...
159 lines87%
Loading...
misc/
3 lines100%
Loading...
tests/
browse/
views/
4 lines100%
Loading...
4 lines90%
Loading...
4 lines98%
Loading...
7 lines100%
Loading...
6 lines97%
Loading...
common/
27 lines100%
Loading...
23 lines100%
Loading...
misc/
5 lines100%
Loading...

Diff 10489

View Options

swh/web/api/views/identifiers.py

Loading...
View Options

swh/web/browse/identifiers.py

Loading...
View Options

swh/web/browse/utils.py

Loading...
View Options

swh/web/common/identifiers.py

Loading...
View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/misc/badges.py

Loading...
View Options

swh/web/tests/browse/views/test_content.py

Loading...
View Options

swh/web/tests/browse/views/test_directory.py

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
View Options

swh/web/tests/browse/views/test_release.py

Loading...
View Options

swh/web/tests/browse/views/test_revision.py

Loading...
View Options

swh/web/tests/common/test_identifiers.py

Loading...
View Options

swh/web/tests/common/test_utils.py

Loading...
View Options

swh/web/tests/misc/test_badges.py

Loading...
About · Developer information · Legal