Page MenuHomeSoftware Heritage
Differential D2932

cypress: Fix flaky tests related to sidebar
ClosedPublic
Actions

Authored by anlambert on Mar 31 2020, 12:46 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDWAPPSfc6dc3512610: cypress: Fix flaky tests related to sidebar
Summary

Increase wait time when testing sidebar expanding / collapsing to a value greater
than the sidebar animation one (300 ms).

CSS class related to expanded / collapsed sidebar is set at the beginning of the
animation so we are unfortunately forced to use cy.wait() here.

Related to T2341

Diff Detail

Repository
rDWAPPS Web applications
Branch
cypress-fix-flaky-test
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11487
Build 17412: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 17411: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msJenkins > should have less width when collapsed compared to open::Tests / Cypress tests / Run cypress tests / Sidebar tests On Large Screen should have less width when collapsed compared to open
AssertionError: expected 73.5938 to be below 73.5938 at Function.fn.<computed> [as isBelow] (http://localhost:5004/__cypress/runner/cypress_runner.js:121818:34) at getRet (http://localhost:5004/__cypress/runner/cypress_runner.js:125261:16)
707 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
1,889 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
421 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
483 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
View Full Test Results (1 Failed · 478 Passed · 7 Skipped)

Event Timeline

anlambert created this revision.Mar 31 2020, 12:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 31 2020, 12:46 PM
swh-public-ci added a comment.Mar 31 2020, 12:54 PM

Build is green

Patch application report for D2932 (id=10414)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit 53dd528fda4834b33bad43edf7f140b45652b711
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:44:37 2020 +0200

    cypress: Fix flaky tests related to sidebar
    
    Increase wait time when testing sidebar expanding / collapsing to a value greater
    than the sidebar animation one (300 ms).
    
    Closes T2341

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/24/ for more details.

Harbormaster completed remote builds in B11487: Diff 10414.Mar 31 2020, 12:54 PM
olasd accepted this revision.Mar 31 2020, 12:57 PM
olasd added a subscriber: olasd.

Thanks!

This revision is now accepted and ready to land.Mar 31 2020, 12:57 PM
anlambert added a comment.Mar 31 2020, 12:58 PM

I will restart the build a couple of times before landing the diff to be sure it effectively fixes the issue.

swh-public-ci added a comment.Mar 31 2020, 1:04 PM

Build is green

Patch application report for D2932 (id=10414)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit 53dd528fda4834b33bad43edf7f140b45652b711
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:44:37 2020 +0200

    cypress: Fix flaky tests related to sidebar
    
    Increase wait time when testing sidebar expanding / collapsing to a value greater
    than the sidebar animation one (300 ms).
    
    Closes T2341

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/25/ for more details.

swh-public-ci added a comment.Mar 31 2020, 1:13 PM

Build has FAILED

Patch application report for D2932 (id=10414)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit 53dd528fda4834b33bad43edf7f140b45652b711
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:44:37 2020 +0200

    cypress: Fix flaky tests related to sidebar
    
    Increase wait time when testing sidebar expanding / collapsing to a value greater
    than the sidebar animation one (300 ms).
    
    Closes T2341

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/26/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/26/console

Harbormaster failed remote builds in B11487: Diff 10414!Mar 31 2020, 1:13 PM
anlambert added a comment.Mar 31 2020, 1:40 PM

Current fix is unfortunately not valid. I need to dig further on this.

anlambert updated this revision to Diff 10417.Mar 31 2020, 3:11 PM

Update:

  • Set sidebar state (collapsed / expanded) once css animation has finished in order to make associated cypress test reliable.
swh-public-ci added a comment.Mar 31 2020, 3:20 PM

Build is green

Patch application report for D2932 (id=10417)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit fc6dc351261017a9a6bc898cb0becf0d0112fd3d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:44:37 2020 +0200

    cypress: Fix flaky tests related to sidebar
    
    Set sidebar state (collapsed / expanded) once css animation has finished
    in order to make associated cypress test reliable.
    
    Also set "enableRemember" option from adminlte PushMenu and remove custom
    code that was doing the same operation as it is not needed anymore
    (see https://adminlte.io/docs/3.0/javascript/push-menu.html).
    
    Closes T2341

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/27/ for more details.

Harbormaster completed remote builds in B11496: Diff 10417.Mar 31 2020, 3:20 PM
swh-public-ci added a comment.Mar 31 2020, 3:31 PM

Build is green

Patch application report for D2932 (id=10417)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit fc6dc351261017a9a6bc898cb0becf0d0112fd3d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:44:37 2020 +0200

    cypress: Fix flaky tests related to sidebar
    
    Set sidebar state (collapsed / expanded) once css animation has finished
    in order to make associated cypress test reliable.
    
    Also set "enableRemember" option from adminlte PushMenu and remove custom
    code that was doing the same operation as it is not needed anymore
    (see https://adminlte.io/docs/3.0/javascript/push-menu.html).
    
    Closes T2341

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/28/ for more details.

swh-public-ci added a comment.Mar 31 2020, 3:39 PM

Build is green

Patch application report for D2932 (id=10417)

Rebasing onto f8ac17e107...

Current branch diff-target is up to date.
Changes applied before test
commit fc6dc351261017a9a6bc898cb0becf0d0112fd3d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Mar 31 12:44:37 2020 +0200

    cypress: Fix flaky tests related to sidebar
    
    Set sidebar state (collapsed / expanded) once css animation has finished
    in order to make associated cypress test reliable.
    
    Also set "enableRemember" option from adminlte PushMenu and remove custom
    code that was doing the same operation as it is not needed anymore
    (see https://adminlte.io/docs/3.0/javascript/push-menu.html).
    
    Closes T2341

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/29/ for more details.

Closed by commit rDWAPPSfc6dc3512610: cypress: Fix flaky tests related to sidebar (authored by anlambert). · Explain WhyMar 31 2020, 3:53 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSfc6dc3512610: cypress: Fix flaky tests related to sidebar.

Revision Contents
Changeset List

PathSize
cypress/
integration/
8 lines

Diff 10414

View Options

cypress/integration/sidebar.spec.js

Loading...
About · Developer information · Legal